linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Maxey <dwm@bebe.enoyolf.org>
To: Mike Christie <michaelc@cs.wisc.edu>,
	Ravi Anand <ravi.anand@qlogic.com>,
	David Somayajulu <davidcs2005@gmail.com>,
	Duane Grigsby <duane.grigsby@qlogic.com>
Cc: linux-scsi@vger.kernel.org, dwm@austin.ibm.com
Subject: [RFC] qla4xxx: TODO for re-submission
Date: Sat, 10 Jun 2006 20:16:55 -0500	[thread overview]
Message-ID: <8889.1149988615@bebe.enoyolf.org> (raw)

Subject: [RFC] qla4xxx: TODO for re-submission

Howdy!

The qla4xxx driver for the QLogic ISP4XXX chipset will be getting a
little janitorial love along the lines of:

A) a rework of the 2006-06-06 Qlogic submitted qla4xxx code to get the
   driver to be in line with the kernel coding style.
B) being made more compliant with the scsi_mid_low_api.txt.  Being
   compiled for M$ does not count as an alternative OS. :)  In
   particular, move all the code to single .c file.  If and when
   another chipset comes along that can utilize some of the bits, look
   into splitting it back up.
C) removal of unreachable or unused code.
D) a rework of the function layout and size, including linewidth adjustments
E) fixups to printk formatting, and moving to dev_printk().  For the
   first pass, just remove the debug printk()'s

This will not be a re-write of the driver per se, just a refactoring
going on in parallel to the work of the QLogic folks and mike, in an
effort to get this driver into mainline.

The plan is to:
1) submit the Documentation/LICENSE.qla4xxx.txt file and check
   the provenance with the original submitters..
2) pull all the data structs into the file, swizzle the types to be
   kernel compliant.
3) pull the core driver initialization (module_init(), pci init et al)
   into the file drivers/scsi/qla4xxx.c
4) add the iscsi transport code.
5) add the block layer code.
6) add the device firmware access.
7) add the hooks for the Kconfig and Makefile

Does this appear to be a workable plan?  Should the struct cleanup
wait and come in on an as needed basis?

All comments will be appreciated.

++doug



             reply	other threads:[~2006-06-11  1:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-11  1:16 Doug Maxey [this message]
2006-06-12 16:49 ` [RFC] qla4xxx: TODO for re-submission Ravi Anand
2006-06-12 16:52   ` Mike Christie
2006-06-12 16:57     ` Ravi Anand
2006-06-12 19:08     ` Doug Maxey
2006-06-12 19:01   ` Doug Maxey
2006-06-12 17:43 ` Mike Christie
2006-06-12 17:44   ` Mike Christie
2006-06-12 19:04   ` Doug Maxey
2006-06-12 20:05     ` Mike Christie
2006-06-12 18:05 ` Mike Christie
2006-06-12 21:10   ` Ravi Anand
2006-06-12 21:35     ` Mike Christie
2006-06-12 22:35       ` Mike Christie
2006-06-12 22:50         ` Ravi Anand
2006-06-12 22:43       ` Ravi Anand
2006-06-13  3:30         ` Mike Christie
2006-06-13  3:48           ` Doug Maxey
2006-06-13  4:31             ` Jeff Garzik
2006-06-13  5:00               ` Doug Maxey
2006-06-13 12:16               ` berthiaume_wayne
2006-06-15  0:35           ` Ravi Anand
2006-06-15  0:43           ` Ravi Anand
2006-06-15 17:31             ` Mike Christie
  -- strict thread matches above, loose matches on Subject: below --
2006-06-16 22:32 David Somayajulu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8889.1149988615@bebe.enoyolf.org \
    --to=dwm@bebe.enoyolf.org \
    --cc=davidcs2005@gmail.com \
    --cc=duane.grigsby@qlogic.com \
    --cc=dwm@austin.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=ravi.anand@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).