Re: [PATCH v2 17/35] scsi: ufshcd: Convert to scsi_exec_req

Bart Van Assche
2022-09-30T18:03:45Z

On 9/28/22 19:53, Mike Christie wrote:
> scsi_execute* is going to be removed. Convert to scsi_exec_req so
> we pass all args in a scsi_exec_args struct.
>
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
> drivers/ufs/core/ufshcd.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index a202d7d5240d..fdea6809ec5c 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -8781,8 +8781,13 @@ static int ufshcd_set_dev_pwr_mode(struct ufs_hba *hba,
> remaining = deadline - jiffies;
> if (remaining <= 0)
> break;
> - ret = scsi_execute(sdp, cmd, DMA_NONE, NULL, 0, NULL, &sshdr,
> - remaining / HZ, 0, 0, RQF_PM, NULL);
> + ret = scsi_exec_req(((struct scsi_exec_args) {
> + .sdev = sdp,
> + .cmd = cmd,
> + .data_dir = DMA_NONE,
> + .sshdr = &sshdr,
> + .timeout = remaining / HZ,
> + .req_flags = RQF_PM }));
> if (!scsi_status_is_check_condition(ret) ||
> !scsi_sense_valid(&sshdr) ||
> sshdr.sense_key != UNIT_ATTENTION)

Acked-by: Bart Van Assche <bvanassche@acm.org>