From: Markus Elfring <Markus.Elfring@web.de>
To: Jianhao Xu <jianhao.xu@seu.edu.cn>, Zilin Guan <zilin@seu.edu.cn>,
linux-scsi@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Justin Tee <justin.tee@broadcom.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Paul Ely <paul.ely@broadcom.com>
Subject: Re: [PATCH v2 1/3] scsi: lpfc: Fix memory leak in lpfc_config_port_post()
Date: Tue, 30 Dec 2025 17:01:32 +0100 [thread overview]
Message-ID: <8ab71d11-ef77-4181-a5d5-e785576c85be@web.de> (raw)
In-Reply-To: <20251230145858.1356864-2-zilin@seu.edu.cn>
…
> +++ b/drivers/scsi/lpfc/lpfc_init.c
…
> @@ -550,8 +549,7 @@ lpfc_config_port_post(struct lpfc_hba *phba)
> if (phba->intr_type == MSIX) {
> rc = lpfc_config_msi(phba, pmb);
> if (rc) {
> - mempool_free(pmb, phba->mbox_mem_pool);
> - return -EIO;
> + goto out_free;
> }
You may omit curly brackets here.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc3#n197
> rc = lpfc_sli_issue_mbox(phba, pmb, MBX_POLL);
> if (rc != MBX_SUCCESS) {
…
Regards,
Markus
next prev parent reply other threads:[~2025-12-30 16:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 14:58 [PATCH v2 0/3] scsi: lpfc: Fix multiple memory leaks in error paths Zilin Guan
2025-12-30 14:58 ` [PATCH v2 1/3] scsi: lpfc: Fix memory leak in lpfc_config_port_post() Zilin Guan
2025-12-30 16:01 ` Markus Elfring [this message]
2025-12-31 15:07 ` Zilin Guan
2025-12-30 14:58 ` [PATCH v2 2/3] scsi: lpfc: Fix memory leak in lpfc_sli4_driver_resource_setup() Zilin Guan
2025-12-30 14:58 ` [PATCH v2 3/3] scsi: lpfc: Fix memory leak in lpfc_cmpl_plogi_plogi_issue() Zilin Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ab71d11-ef77-4181-a5d5-e785576c85be@web.de \
--to=markus.elfring@web.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jianhao.xu@seu.edu.cn \
--cc=justin.tee@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=paul.ely@broadcom.com \
--cc=zilin@seu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox