From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75EA5C433FE for ; Sun, 27 Feb 2022 10:24:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229569AbiB0KYz (ORCPT ); Sun, 27 Feb 2022 05:24:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230110AbiB0KYx (ORCPT ); Sun, 27 Feb 2022 05:24:53 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53FE01E3D5 for ; Sun, 27 Feb 2022 02:24:17 -0800 (PST) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id F22EB3FCA6 for ; Sun, 27 Feb 2022 10:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645957455; bh=gFalKRe8JlGPelOo/R9VR3IL4dqyePAFZHwDnlwRlEk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jLh60SiGk1ssq7pESJe+eHLauvQRxegd9y4n5MepDLsTf7G/se5F+ZvJjBpVEqCwq BJ+7tkFSX2/JdS269FU8Rew781ru9i2ukSQ4xvFh4E8P60jMfRGKP7jzWfJlIMxRuR ii1hm9g3VUt7JlkDpPO131VuAngiQm3AxZFagFCPQEtytZ2/w+XVTfLrm8iVIVg4UV AmF4Y0irG+GRFZ62ZmZEYo8j2SmOuvoXfKALFGhnyChSoTN5oabPb9HOmmAEQvF+no FZ/d5p8OxpWn101hA6z+VI7nJvALatzHaYo6AOQs4ZvUjyJb/gVK2eCnHROsx0QCYJ A7emELjVLb5QQ== Received: by mail-ed1-f72.google.com with SMTP id o5-20020a50c905000000b00410effbf65dso4051084edh.17 for ; Sun, 27 Feb 2022 02:24:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gFalKRe8JlGPelOo/R9VR3IL4dqyePAFZHwDnlwRlEk=; b=SW1BO9CxVeIjZXW9k/0krmqObef/OOIaHe/20zdrnHJjquuvIUqCVhzp+LDro/7eLP 2HKrgauR6CnhsQLj82qjw1oQzA2Uot46GXnKE0g9cWzyEb7buQJTrVQd/FgQPTSuQsHo kI2Ki7Jw8Pt8gjxIX36+EpBmVC0dV7AjrjGIFsw9aLyoz5oqRK7Q0dI/hsLT/JuUY/N2 SZJQ/6xhW6L82c+WTE8Am2Y2Rh2x/GHtXSEkoI5foXsTrfgOgNWGGAtfrh6wDmxO6bvR 7JlKakD03HJ/lYJ8CCEHhtTMh9VldZRRcdRxrMWoYpKoFSfIzrP4or8kkatv2kOtCX8b ce2w== X-Gm-Message-State: AOAM533fatdNOer5u3+Q+dHrg6rUUi0YI+V15JzXb7bbaWuan2RejfHv kEtDIwGmSlIp1LQjBRjuB6m+sK/1aoHOHPQwCnnr1OrewNxLl/8LYiBlaRzxQPssHGCLhdWxBAJ OilHqNLDVPwoL3qWsF4e3u/hqXxJt3xFw2E56FoU= X-Received: by 2002:a17:906:d968:b0:6d0:fc05:bdc3 with SMTP id rp8-20020a170906d96800b006d0fc05bdc3mr11342162ejb.719.1645957455521; Sun, 27 Feb 2022 02:24:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJwl3Y8M/TgNxwE3/0YwpdpPk65xBu71Ro8HLF5s9NgyHBBUg649P8bP26tAeg/OT/XsQvSm8w== X-Received: by 2002:a17:906:d968:b0:6d0:fc05:bdc3 with SMTP id rp8-20020a170906d96800b006d0fc05bdc3mr11342141ejb.719.1645957455350; Sun, 27 Feb 2022 02:24:15 -0800 (PST) Received: from [192.168.0.133] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id el9-20020a170907284900b006cf8e3c83e3sm3243768ejc.168.2022.02.27.02.24.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Feb 2022 02:24:14 -0800 (PST) Message-ID: <8ba5fb1b-2b5f-e625-0dbe-2acc3b6656e7@canonical.com> Date: Sun, 27 Feb 2022 11:24:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 01/15] dt-bindings: ufs: add common platform bindings Content-Language: en-US To: Rob Herring Cc: Alim Akhtar , Avri Altman , Andy Gross , Bjorn Andersson , Wei Xu , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , "James E.J. Bottomley" , "Martin K. Petersen" , Jan Kotas , Li Wei , Stanley Chu , Yaniv Gardi , linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20220222145854.358646-1-krzysztof.kozlowski@canonical.com> <20220222145854.358646-2-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 25/02/2022 20:26, Rob Herring wrote: > On Tue, Feb 22, 2022 at 03:58:40PM +0100, Krzysztof Kozlowski wrote: >> Add bindings for common parts (platform) of Universal Flash Storage >> (UFS) Host Controllers in dtschema format. >> >> The 'freq-table-hz' is not correct in dtschema, because '-hz' suffix >> defines uint32 type, not an array. Therefore deprecate 'freq-table-hz' >> and use 'freq-table' instead. > > -hz is an array type. We can extend it to matrix if needed. > > I do think this property is a bit questionable. Do we really need a > minimum in DT and if not, wouldn't assigned-clocks-rate work? Or an OPP > table. > I think the proper solution is OPP table, see also comments from Bjorn: https://lore.kernel.org/all/YhUodbzxx4wbr+gy@ripper/ I would rather refrain from converting it to OPP tables, because I won't be able to test any changes in the driver. Best regards, Krzysztof