From: John Garry <john.garry@huawei.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] scsi: hisi_sas: remove stray fallthrough annotation
Date: Thu, 17 Mar 2022 08:47:24 +0000 [thread overview]
Message-ID: <8ea15300-9301-a54e-8a65-78aa46745d08@huawei.com> (raw)
In-Reply-To: <20220317075214.GC25237@kili>
On 17/03/2022 07:52, Dan Carpenter wrote:
> This case statement doesn't fall through any more so remove the
> fallthrough annotation.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks
Acked-by: John Garry <john.garry@huawei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 461ef8a76c4c..4bda2f6cb352 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -442,7 +442,6 @@ void hisi_sas_task_deliver(struct hisi_hba *hisi_hba,
> case SAS_PROTOCOL_INTERNAL_ABORT:
> hisi_sas_task_prep_abort(hisi_hba, slot);
> break;
> - fallthrough;
> default:
> return;
> }
next prev parent reply other threads:[~2022-03-17 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 7:52 [PATCH] scsi: hisi_sas: remove stray fallthrough annotation Dan Carpenter
2022-03-17 8:47 ` John Garry [this message]
2022-03-30 3:53 ` Martin K. Petersen
2022-04-07 13:35 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ea15300-9301-a54e-8a65-78aa46745d08@huawei.com \
--to=john.garry@huawei.com \
--cc=dan.carpenter@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox