Re: [PATCH v2 02/35] scsi: Allow passthrough to override what errors to retry

michael.christie
2022-09-29T16:39:56Z

On 9/29/22 6:00 AM, Martin Wilck wrote:
>> +               if (!failure->result)
>> +                       break;
>> +
>> +               if (failure->result == SCMD_FAILURE_ANY)
>> +                       goto maybe_retry;
>> +
>> +               if (host_byte(scmd->result) & host_byte(failure-
>>> result)) {
>> +                       goto maybe_retry;
>
> Using "&" here needs explanation. The host byte is not a bit mask.
>
>> +               } else if (get_status_byte(scmd) &
>> +                          __get_status_byte(failure->result)) {
>
> See above.
>
I had a brain far for host/status bytes. Will fix throughout the set.