Re: [PATCH] ufs: core: Initialize a variable mode for PA_PWRMODE

[Bart Van Assche <bvanassche@acm.org>]

On 10/2/25 12:00 AM, Wonkon Kim wrote:
>   static bool ufshcd_is_pwr_mode_restore_needed(struct ufs_hba *hba)
>   {
>   	struct ufs_pa_layer_attr *pwr_info = &hba->pwr_info;
> -	u32 mode;
> +	u32 mode = 0;
>   
>   	ufshcd_dme_get(hba, UIC_ARG_MIB(PA_PWRMODE), &mode);

Wouldn't it be better to check the ufshcd_dme_get() return value rather
than to zero-initialize 'mode'? I think that would make 
ufshcd_is_pwr_mode_restore_needed() easier to read compared to applying
the above patch.

Thanks,

Bart.