From: Bart Van Assche <bvanassche@acm.org>
To: j-young.choi@samsung.com, ALIM AKHTAR <alim.akhtar@samsung.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 5/7] scsi: ufs: wb: Add ufshcd_is_wb_buf_flush_allowed()
Date: Wed, 27 Jul 2022 12:44:01 -0700 [thread overview]
Message-ID: <90ef5f84-1e4e-d93e-5ee9-acdf36109827@acm.org> (raw)
In-Reply-To: <20220727071024epcms2p70366b54ac8eca3758b7cf4336e0d457c@epcms2p7>
On 7/27/22 00:10, Jinyoung CHOI wrote:
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
> index 94bcfec98fb8..78adc556444a 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> @@ -1017,6 +1017,12 @@ static inline bool ufshcd_is_wb_allowed(struct ufs_hba *hba)
> return hba->caps & UFSHCD_CAP_WB_EN;
> }
>
> +static inline bool ufshcd_is_wb_buf_flush_allowed(struct ufs_hba *hba)
> +{
> + return ufshcd_is_wb_allowed(hba) &&
> + !(hba->quirks & UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL);
> +}
Since this function is only used inside the UFS driver core it should be
added in drivers/ufs/core/ufshcd-priv.h instead of include/ufs/ufshcd.h.
Thanks,
Bart.
next prev parent reply other threads:[~2022-07-27 19:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220727065904epcms2p60a7a56101785ddefa55c82b3cc25116d@epcms2p6>
2022-07-27 6:59 ` [PATCH v4 0/7] scsi: ufs: wb: Add sysfs attribute and cleanup Jinyoung CHOI
2022-07-27 7:04 ` [PATCH v4 1/7] scsi: ufs: wb: Move ufshcd_is_wb_allowed() to callee Jinyoung CHOI
2022-07-27 7:05 ` [PATCH v4 2/7] scsi: ufs: wb: Change wb_enabled condition test Jinyoung CHOI
2022-07-27 13:49 ` Bean Huo
2022-07-27 7:07 ` [PATCH v4 3/7] scsi: ufs: wb: Change functions name and modify Jinyoung CHOI
2022-07-27 7:08 ` [PATCH v4 4/7] scsi: ufs: wb: Add explicit flush sysfs attribute Jinyoung CHOI
2022-07-27 7:10 ` [PATCH v4 5/7] scsi: ufs: wb: Add ufshcd_is_wb_buf_flush_allowed() Jinyoung CHOI
2022-07-27 7:11 ` [PATCH v4 6/7] scsi: ufs: wb: Modify messages Jinyoung CHOI
2022-07-27 7:12 ` [PATCH v4 7/7] scsi: ufs: wb: Move the comment to the right position Jinyoung CHOI
2022-07-27 17:50 ` [PATCH v4 5/7] scsi: ufs: wb: Add ufshcd_is_wb_buf_flush_allowed() Bean Huo
2022-07-27 19:44 ` Bart Van Assche [this message]
2022-07-28 1:18 ` Jinyoung CHOI
2022-07-27 17:43 ` [PATCH v4 4/7] scsi: ufs: wb: Add explicit flush sysfs attribute Bean Huo
2022-07-28 0:54 ` Jinyoung CHOI
2022-07-27 13:16 ` [PATCH v4 1/7] scsi: ufs: wb: Move ufshcd_is_wb_allowed() to callee Bean Huo
2022-07-28 6:21 ` Jinyoung CHOI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90ef5f84-1e4e-d93e-5ee9-acdf36109827@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=j-young.choi@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox