From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68A4847F77 for ; Thu, 29 Feb 2024 08:09:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709194145; cv=none; b=cPTo924yhmB/KluMXApUGEqjWMS/y2v6fvj/1Cqn3a50NQK93sv/qo55Va0H//FqtXmVhskG579n38LsQ5wEuXVyS1KoAkgN3wkOSXsIuIcez8W61HPVVYJJ+cJ5zFtpzIFD1bNBzVLOlTSuhh7A6rn073BpI6UHCbd7c+TZ8VY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709194145; c=relaxed/simple; bh=kurHTtq2rspvJgMv43M46KVUb0L5q+U22TYTVcEIAOs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Nbu3vfXOZQnk4vgnXMgUq+7wEy5EjRfqTZIJBp1LRUu2/3U25Z5OiCzDrVr48WZEFqj0RMnaGCa7f5w4PoMTXQegbWVU+iVOJYmBnEujADHi8hxzD90sVfKCi33HNypJbMg9m8/IJkzQ+XJociuZqeDimYewCSe87v6380Cr6MM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=cHDNc0b6; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="cHDNc0b6" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2d220e39907so7457341fa.1 for ; Thu, 29 Feb 2024 00:09:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1709194141; x=1709798941; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+6fUyesk9XtuEUwAKGfVFcYKYn8nCxiz5t4vTL0pI4o=; b=cHDNc0b6X2W23utcpiCwLBIqvSth4LUen5f9nw77arxlFGQBjpPQ5ivkrduHmTigXF cHLxCZtjh8n/2QvtIUVLmTsVgIUdIt5ljDko64YcwP4X3K9XOBnOta4REycdFwlusVHi mvSy0SjFToBz6RdCd+hMdpF1ZNjT7AjmlbMBL2iL6EpnYwaOKPC6ZSbKqdsPZJX2xtUo JDKrdRW0F6jENZJ/9SD/Akvxlb1acvsVNIMSepB6ynsCV8kQaxpC7PWu+mdG4qutEixq rZNfYdJbs2ZQrB23pZWW13wD1Sim9ceJBxZZFkDhyfzMBPNi6TJpDUVJOAVaOuEQTjI3 4/sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709194141; x=1709798941; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+6fUyesk9XtuEUwAKGfVFcYKYn8nCxiz5t4vTL0pI4o=; b=U5H3zqzEwLlgW5CoZ9naM4/eNSz6xcAAw6/NNyO4ovMeSnQ4Ck7nd3gXMPUvebOSVl e3OWDH9voMO73oTzqsjIOBcMXEIo364gUjhOZZBbXd+Q3mUHKQqe6bsRDXtTyrY2Mw6H ULB25Lwh5q0WjLFtD0x0lu3cp1nYLxUstE/26clhM8WS5W+CTEWmoT7BWzppyDrxpvpI u4M/SLsKZAvITTq6BV3KV4jgmPluXIsnDsJJ2wkOadzoR78sG9gKwNBKZWHp5Nm1xPBt 8mGoVOWxEKcF1yutsQJEAQIveu2S7UZM/nNsNxciYsSg70xaz0Df6uVGUVi68/zkhP8j L4uw== X-Forwarded-Encrypted: i=1; AJvYcCVYs0A5sfS/9q1pCdmqi7x/U0T2ODfbhLlrxTaUpTmho5W1G1MoF05Ro5ZgLQJ/4mx40W1y40urkCtbDkn0ZuZ5haZ173OEF/T24g== X-Gm-Message-State: AOJu0Ywd2eWytdJY8I1aLqx/QCVqmVxXPVgxBeQf0JNml4JScr/obneF U2+k3yl4KkhSgKdCclAc1+p8lj+8gA2uHyt87Fyzc/ti+qs8W3hxMVlMdNwZ+rk= X-Google-Smtp-Source: AGHT+IEioEBenaGBregM2gF1RR+HQbJWqUnI/Hp2B6pwGbY54Du2S+X2nxQx2LKNChi6zePmii8/pQ== X-Received: by 2002:a2e:bc1f:0:b0:2d2:8290:46ff with SMTP id b31-20020a2ebc1f000000b002d2829046ffmr971230ljf.50.1709194141302; Thu, 29 Feb 2024 00:09:01 -0800 (PST) Received: from ?IPV6:2001:a61:1366:6801:d8:8490:cf1a:3274? ([2001:a61:1366:6801:d8:8490:cf1a:3274]) by smtp.gmail.com with ESMTPSA id jn3-20020a05600c6b0300b004128e903b2csm4375201wmb.39.2024.02.29.00.09.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 00:09:01 -0800 (PST) Message-ID: <9263b77e-9ebe-4987-bf7f-8f9fafcf06b3@suse.com> Date: Thu, 29 Feb 2024 09:08:59 +0100 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] USB:UAS:return ENODEV when submit urbs fail with device not attached. To: "WeitaoWang-oc@zhaoxin.com" , Oliver Neukum , stern@rowland.harvard.edu, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net Cc: WeitaoWang@zhaoxin.com, stable@vger.kernel.org References: <20240228111521.3864-1-WeitaoWang-oc@zhaoxin.com> <07e80d55-d766-1781-ffc9-fab9ddcd33e3@zhaoxin.com> <49a365a7-199a-42cd-b8d3-86d72fe5bca6@suse.com> <0b0eefa5-71b6-dc08-d103-72b9aebd9237@zhaoxin.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: <0b0eefa5-71b6-dc08-d103-72b9aebd9237@zhaoxin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 29.02.24 12:19, WeitaoWang-oc@zhaoxin.com wrote: > When alloc urb fail in the same function uas_submit_urbs, > whether we should replace SCSI_MLQUEUE_DEVICE_BUSY with generic > error code -ENOMEM? Such like this: > > @@ -572,7 +571,7 @@ static int uas_submit_urbs(struct scsi_cmnd *cmnd, >          cmdinfo->data_in_urb = uas_alloc_data_urb(devinfo, GFP_ATOMIC, >                              cmnd, DMA_FROM_DEVICE); >          if (!cmdinfo->data_in_urb) > -            return SCSI_MLQUEUE_DEVICE_BUSY; > +            return -ENOMEM; >          cmdinfo->state &= ~ALLOC_DATA_IN_URB; >      } Hi, yes, and then you translate in one central place for the SCSI layer into DID_ERROR or DID_NO_CONNECT. Regards Oliver