Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: kernel test robot <oliver.sang@intel.com>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com,
	linux-scsi@vger.kernel.org, jejb@linux.ibm.com,
	martin.petersen@oracle.com, bvanassche@acm.org,
	linux-kernel@vger.kernel.org, dgilbert@interlog.com
Subject: Re: [PATCH RESEND v2 09/11] scsi: scsi_debug: Drop sdebug_dev_info.num_in_q
Date: Mon, 20 Mar 2023 11:41:51 +0000	[thread overview]
Message-ID: <92a2d9c4-cc7a-6a26-07ea-b49ecdc920cc@oracle.com> (raw)
In-Reply-To: <202303201334.18b30edc-oliver.sang@intel.com>

On 20/03/2023 05:31, kernel test robot wrote:
> 
> Greeting,
> 
> FYI, we noticed blktests.scsi/004.fail due to commit (built with gcc-11):
> 
> commit: 76fe86662c283bf322ac1e032c46ddaa0da5cb16 ("[PATCH RESEND v2 09/11] scsi: scsi_debug: Drop sdebug_dev_info.num_in_q")
> url: https://github.com/intel-lab-lkp/linux/commits/John-Garry/scsi-scsi_debug-Don-t-hold-driver-host-struct-pointer-in-host-hostdata/20230313-173528
> base: https://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git for-next
> patch link: https://lore.kernel.org/all/20230313093114.1498305-10-john.g.garry@oracle.com/
> patch subject: [PATCH RESEND v2 09/11] scsi: scsi_debug: Drop sdebug_dev_info.num_in_q
> 
> in testcase: blktests
> version: blktests-x86_64-e3f2ca5-1_20230228
> with following parameters:
> 
> 	disk: 1HDD
> 	test: scsi-group-02
> 
> 
> 
> on test machine: 16 threads 1 sockets Intel(R) Xeon(R) CPU D-1541 @ 2.10GHz (Broadwell-DE) with 48G memory
> 
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
> 
> 
> 
> 
> If you fix the issue, kindly add following tag
> | Reported-by: kernel test robot <oliver.sang@intel.com>
> | Link: https://lore.kernel.org/oe-lkp/202303201334.18b30edc-oliver.sang@intel.com
> 
> 
> 2023-03-18 00:18:58 sed "s:^:scsi/:" /lkp/benchmarks/blktests/tests/scsi-group-02
> 2023-03-18 00:18:58 ./check scsi/004 scsi/005
> scsi/004 (ensure repeated TASK SET FULL results in EIO on timing out command)
> scsi/004 (ensure repeated TASK SET FULL results in EIO on timing out command) [failed]
>      runtime    ...  1.467s
>      --- tests/scsi/004.out	2023-02-28 16:52:49.000000000 +0000
>      +++ /lkp/benchmarks/blktests/results/nodev/scsi/004.out.bad	2023-03-18 00:19:00.232079954 +0000
>      @@ -1,3 +1,2 @@
>       Running scsi/004
>      -Input/output error
>       Test complete
> 

I'll check this now.

> 
> 
> To reproduce:
> 
>          git clone https://github.com/intel/lkp-tests.git
>          cd lkp-tests
>          sudo bin/lkp install job.yaml           # job file is attached in this email
>          bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
>          sudo bin/lkp run generated-yaml-file
> 
>          # if come across any failure that blocks the test,
>          # please remove ~/.lkp and /lkp dir to run from a clean state.
> 
> 
> 


  reply	other threads:[~2023-03-20 11:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13  9:31 [PATCH RESEND v2 00/11] scsi_debug: Some minor improvements John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 01/11] scsi: scsi_debug: Don't hold driver host struct pointer in host->hostdata[] John Garry
2023-03-14  2:34   ` Douglas Gilbert
2023-03-16  8:48     ` John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 02/11] scsi: scsi_debug: Stop setting devip->sdbg_host twice John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 03/11] scsi: scsi_debug: Drop scsi_debug_abort() NULL pointer checks John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 04/11] scsi: scsi_debug: Drop scsi_debug_device_reset() " John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 05/11] scsi: scsi_debug: Drop scsi_debug_target_reset() " John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 06/11] scsi: scsi_debug: Drop scsi_debug_bus_reset() " John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 07/11] scsi: scsi_debug: Drop scsi_debug_host_reset() device NULL pointer check John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 08/11] scsi: scsi_debug: Drop check for num_in_q exceeding queue depth John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 09/11] scsi: scsi_debug: Drop sdebug_dev_info.num_in_q John Garry
2023-03-20  5:31   ` kernel test robot
2023-03-20 11:41     ` John Garry [this message]
2023-03-22 13:36       ` John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 10/11] scsi: scsi_debug: Get command abort feature working again John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 11/11] scsi: scsi_debug: Add poll mode deferred completions to statistics John Garry
2023-03-17  3:27 ` [PATCH RESEND v2 00/11] scsi_debug: Some minor improvements Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92a2d9c4-cc7a-6a26-07ea-b49ecdc920cc@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=bvanassche@acm.org \
    --cc=dgilbert@interlog.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=martin.petersen@oracle.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox