From: Johannes Thumshirn <jthumshirn@suse.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
linux-scsi-owner@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: Do not attach VPD to devices that don't support it
Date: Fri, 01 Apr 2016 09:44:41 +0200 [thread overview]
Message-ID: <942d42b307ff882c51e468104035f6e5@suse.de> (raw)
In-Reply-To: <1459493857-4724-2-git-send-email-hare@suse.de>
On 2016-04-01 08:57, Hannes Reinecke wrote:
> The patch "scsi: rescan VPD attributes" introduced a regression in
> which
> devices that don't support VPD were being scanned for VPD attributes
> anyway. This could cause issues for this parts and should be avoided
> so
> the check for scsi_level has been moved out of scsi_add_lun and into
> scsi_attach_vpd so that all callers will not scan VPD for devices that
> don't support it.
>
> Fixes: 09e2b0b14690 ("scsi: rescan VPD attributes")
>
> Suggested-by: Alexander Duyck <aduyck@mirantis.com>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
next prev parent reply other threads:[~2016-04-01 7:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 6:57 [PATCH 0/2] scsi: vpd sanity checks Hannes Reinecke
2016-04-01 6:57 ` [PATCH 1/2] scsi: Do not attach VPD to devices that don't support it Hannes Reinecke
2016-04-01 7:44 ` Johannes Thumshirn [this message]
2016-04-04 23:12 ` Martin K. Petersen
2016-04-01 6:57 ` [PATCH 2/2] scsi: vpd pages are mandatory for SPC-2 Hannes Reinecke
2016-04-01 7:45 ` Johannes Thumshirn
2016-04-11 21:23 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2016-01-21 6:35 [PATCH 0/2] scsi: Fix endless loop of ATA hard resets due to VPD reads Alexander Duyck
2016-01-21 6:35 ` [PATCH 1/2] scsi: Do not attach VPD to devices that don't support it Alexander Duyck
2016-01-21 7:37 ` Hannes Reinecke
2016-01-21 17:05 ` Alexander Duyck
2016-02-02 1:22 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=942d42b307ff882c51e468104035f6e5@suse.de \
--to=jthumshirn@suse.de \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).