From: Bart Van Assche <bvanassche@acm.org>
To: keosung.park@samsung.com,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH v2 1/7] scsi: ufs: Declare ufshcd_mcq_poll_cqe_lock() once
Date: Fri, 28 Jun 2024 12:28:03 -0700 [thread overview]
Message-ID: <94929ee4-7eba-47f7-b516-1e11a484c43c@acm.org> (raw)
In-Reply-To: <20240628021332epcms2p33801c04cb32d44c5fe3d396a6a45b256@epcms2p3>
On 6/27/24 7:13 PM, Keoseong Park wrote:
>> ufshcd_mcq_poll_cqe_lock() is declared in include/ufs/ufshcd.h and also in
>> drivers/ufs/core/ufshcd-priv.h. Remove the declaration from the latter file.
>
> Hi Bart,
>
> The functions below seem to be the same case.
> - ufshcd_mcq_write_cqis()
> - ufshcd_mcq_read_cqis()
> - ufshcd_mcq_config_mac()
> - ufshcd_mcq_make_queues_operational()
>
> How about including these cases in the patch as well?
I will do that.
Thanks,
Bart.
next prev parent reply other threads:[~2024-06-28 19:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 19:58 [PATCH v2 0/7] UFS patches for kernel 6.11 Bart Van Assche
2024-06-27 19:58 ` [PATCH v2 1/7] scsi: ufs: Declare ufshcd_mcq_poll_cqe_lock() once Bart Van Assche
2024-06-28 2:13 ` Keoseong Park
2024-06-28 19:28 ` Bart Van Assche [this message]
2024-06-27 19:58 ` [PATCH v2 2/7] scsi: ufs: Initialize struct uic_command once Bart Van Assche
2024-06-27 19:58 ` [PATCH v2 3/7] scsi: ufs: Remove two constants Bart Van Assche
2024-06-28 3:14 ` Keoseong Park
2024-06-27 19:58 ` [PATCH v2 4/7] scsi: ufs: Rename the MASK_TRANSFER_REQUESTS_SLOTS constant Bart Van Assche
2024-06-27 19:58 ` [PATCH v2 5/7] scsi: ufs: Initialize hba->reserved_slot earlier Bart Van Assche
2024-06-27 19:58 ` [PATCH v2 6/7] scsi: ufs: Inline ufshcd_mcq_vops_get_hba_mac() Bart Van Assche
2024-06-27 19:58 ` [PATCH v2 7/7] scsi: ufs: Make .get_hba_mac() optional Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94929ee4-7eba-47f7-b516-1e11a484c43c@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=avri.altman@wdc.com \
--cc=keosung.park@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox