From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@infradead.org>, Po-Wen Kao <powenkao@google.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER"
<linux-scsi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] scsi: ufs: core: Fix error handler encryption support
Date: Wed, 10 Dec 2025 09:44:52 -0800 [thread overview]
Message-ID: <955ba65e-424b-4968-9541-ab235a7bafd3@acm.org> (raw)
In-Reply-To: <aTkXqslvwMOz2TUG@infradead.org>
On 12/9/25 10:48 PM, Christoph Hellwig wrote:
> As mentioned last round, why are you even calling into the crypto
> code here? Calling that for a request without a crypt context,
> which includes all of them that do not transfer any data makes no
> sense to start with.
ufshcd_prepare_lrbp_crypto() only has one caller. Moving the new test
from inside ufshcd_prepare_lrbp_crypto() into its caller should be easy.
Thanks,
Bart.
next prev parent reply other threads:[~2025-12-10 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 2:52 [PATCH 1/1] scsi: ufs: core: Fix error handler encryption support Po-Wen Kao
2025-12-09 17:53 ` Bart Van Assche
2025-12-10 6:48 ` Christoph Hellwig
2025-12-10 17:44 ` Bart Van Assche [this message]
2025-12-15 5:58 ` Christoph Hellwig
2025-12-15 16:47 ` Bart Van Assche
2025-12-16 10:44 ` Christoph Hellwig
2025-12-16 17:57 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=955ba65e-424b-4968-9541-ab235a7bafd3@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=powenkao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox