From: Daejun Park <daejun7.park@samsung.com>
To: "avri.altman" <avri.altman@wdc.com>, jejb <jejb@linux.ibm.com>,
"martin.petersen" <martin.petersen@oracle.com>,
asutoshd <asutoshd@codeaurora.org>, beanhuo <beanhuo@micron.com>,
"stanley.chu" <stanley.chu@mediatek.com>,
cang <cang@codeaurora.org>, bvanassche <bvanassche@acm.org>,
ALIM AKHTAR <alim.akhtar@samsung.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Sang-yoon Oh <sangyoon.oh@samsung.com>,
Sung-Jun Park <sungjun07.park@samsung.com>,
yongmyung lee <ymhungry.lee@samsung.com>,
Jinyoung CHOI <j-young.choi@samsung.com>,
Adel Choi <adel.choi@samsung.com>,
SEUNGUK SHIN <seunguk.shin@samsung.com>
Subject: RE: [PATCH] scsi: ufs: Fix NOP OUT timeout value
Date: Tue, 15 Sep 2020 09:11:54 +0900 [thread overview]
Message-ID: <963815509.21600129983068.JavaMail.epsvc@epcpadp2> (raw)
In-Reply-To: CGME20200915001154epcms2p877997a80b59356b19d17eee0c100c74e@epcms2p8
> In some Samsung UFS devices, there is some booting fail issue with
> low-power UFS device. The reason of this issue is the UFS device has a
> little bit longer latency for NOP OUT response. It causes booting fail
> because NOP OUT command is issued during initialization to check whether
> the device transport protocol is ready or not. This issue is resolved by
> releasing NOP_OUT_TIMEOUT value.
>
> NOP_OUT_TIMEOUT: 30ms -> 50ms
>
> Signed-off-by: Daejun Park <daejun7.park@samsung.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 06e2439d523c..5cbd0e9e4ef8 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -36,8 +36,8 @@
>
> /* NOP OUT retries waiting for NOP IN response */
> #define NOP_OUT_RETRIES 10
> -/* Timeout after 30 msecs if NOP OUT hangs without response */
> -#define NOP_OUT_TIMEOUT 30 /* msecs */
> +/* Timeout after 50 msecs if NOP OUT hangs without response */
> +#define NOP_OUT_TIMEOUT 50 /* msecs */
>
> /* Query request retries */
> #define QUERY_REQ_RETRIES 3
> --
> 2.17.1
Hello,
Just a gentle reminder that I'd like some feedback.
Any suggestions here?
Thanks,
Daejun
next parent reply other threads:[~2020-09-15 0:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200915001154epcms2p877997a80b59356b19d17eee0c100c74e@epcms2p8>
2020-09-15 0:11 ` Daejun Park [this message]
[not found] <CGME20200902025852epcms2p2a2d4ac934f4fc09233d4272c96df9ff1@epcms2p2>
2020-09-02 2:58 ` [PATCH] scsi: ufs: Fix NOP OUT timeout value Daejun Park
2020-09-15 6:35 ` Avri Altman
2020-09-15 7:08 ` Daejun Park
2020-09-16 0:14 ` Martin K. Petersen
2020-09-22 3:56 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=963815509.21600129983068.JavaMail.epsvc@epcpadp2 \
--to=daejun7.park@samsung.com \
--cc=adel.choi@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=j-young.choi@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sangyoon.oh@samsung.com \
--cc=seunguk.shin@samsung.com \
--cc=stanley.chu@mediatek.com \
--cc=sungjun07.park@samsung.com \
--cc=ymhungry.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox