Re: [PATCH v2 1/2] scsi: ufs: Re-enable WriteBooster after device reset

Stanley Chu
2020-12-09T01:10:32Z

On Tue, 2020-12-08 at 15:13 +0100, Bean Huo wrote:
> On Tue, 2020-12-08 at 21:56 +0800, Stanley Chu wrote:
> > index 08c8a591e6b0..36d367eb8139 100644
> > --- a/drivers/scsi/ufs/ufshcd.h
> > +++ b/drivers/scsi/ufs/ufshcd.h
> > @@ -1221,8 +1221,13 @@ static inline void
> > ufshcd_vops_device_reset(struct ufs_hba *hba)
> > if (hba->vops && hba->vops->device_reset) {
> > int err = hba->vops->device_reset(hba);
> >
> > - if (!err)
> > + if (!err) {
> > ufshcd_set_ufs_dev_active(hba);
> > + if (ufshcd_is_wb_allowed(hba)) {
> > + hba->wb_enabled = false;
> > + hba->wb_buf_flush_enabled = false;
> > + }
> > + }
>
> Stanley,
> how do you think group wb_buf_flush_enabled and wb_enabled to the
> dev_info, since they are UFS device attributes. means they are set only
> when UFS device flags being set.

Hi Bean,

Thanks for your review.

Yes, I agreed that wb related variables is a mess currently. I would
like to clean them up once I have time. Feel free to post your patch if
you want to take it up : )

Thanks,
Stanley Chu

>
> Reviewed-by: Bean Huo <beanhuo@micron.com>
>