Re: [PATCH v2 1/2] scsi: ufs: Re-enable WriteBooster after device reset

Bean Huo
2020-12-14T20:34:16Z

On Wed, 2020-12-09 at 09:09 +0800, Stanley Chu wrote:
> > >
> > > - if (!err)
> > > + if (!err) {
> > > ufshcd_set_ufs_dev_active(hba);
> > > + if (ufshcd_is_wb_allowed(hba)) {
> > > + hba->wb_enabled = false;
> > > + hba->wb_buf_flush_enabled =
> > > false;
> > > + }
> > > + }
> >
> > Stanley,
> > how do you think group wb_buf_flush_enabled and wb_enabled to the
> > dev_info, since they are UFS device attributes. means they are set
> > only
> > when UFS device flags being set.
>
> Hi Bean,
>
> Thanks for your review.
>
> Yes, I agreed that wb related variables is a mess currently. I would
> like to clean them up once I have time. Feel free to post your patch
> if
> you want to take it up : )
>

Hi Stanley
I updated this change in my new "Several changes for UFS WriteBooster"
series patch, are you interested in reviewing that? to help Martin
easier pick up the changes.

Thanks,
Bean