From: Bean Huo <beanhuo@iokpp.de>
To: Jens Wiklander <jens.wiklander@linaro.org>
Cc: avri.altman@wdc.com, bvanassche@acm.org, alim.akhtar@samsung.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
can.guo@oss.qualcomm.com, ulf.hansson@linaro.org,
beanhuo@micron.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver for UFS devices
Date: Mon, 13 Oct 2025 17:42:56 +0200 [thread overview]
Message-ID: <97c39c0cdb6b96d791fe05f8e5496a502a7e6ac6.camel@iokpp.de> (raw)
In-Reply-To: <CAHUa44HYNgiRU5yOrVq8gBwHEEAxGz6TyT0PrBpVOiFfKxYhOQ@mail.gmail.com>
On Mon, 2025-10-13 at 14:22 +0200, Jens Wiklander wrote:
> >
> > For certain memory vendors, the serial number is guaranteed to be unique
> > among
> > all devices.
>
> This is supposed to be generic and not rely on the behavior of only
> some vendors.
>
> >
> > For partitions or regions, we have appended the region number to the end of
> > the
> > CID — please check the patch for details.
>
> Yes, but how do you know that you don't overwrite a part of the serial number?
>
> >
> > Regarding improving CID uniqueness, we could include the OEM ID or product
> > number. However, this would make the CID longer than 16 bytes.
>
> UFS doesn't have a CID, but there's no need for one either. struct
> rpmb_descr has dev_id and dev_id_len. It can be any length, within
> reason.
>
> Cheers,
> Jens
Hi Jens,
how about combining wManufacturerID, wManufactureDate, wDeviceVersion, Serial
Number (in unicode), plus the region number?
Kind regards,
Bean
next prev parent reply other threads:[~2025-10-13 15:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 6:08 [PATCH v2 0/3] Add OP-TEE based RPMB driver for UFS devices Bean Huo
2025-10-01 6:08 ` [PATCH v2 1/3] rpmb: move rpmb_frame struct and constants to common header Bean Huo
2025-10-01 9:48 ` Avri Altman
2025-10-01 19:43 ` Bart Van Assche
2025-10-06 10:07 ` Jens Wiklander
2025-10-06 10:21 ` Ulf Hansson
2025-10-06 10:54 ` Bean Huo
2025-10-01 6:08 ` [PATCH v2 2/3] scsi: ufs: core: fix incorrect buffer duplication in ufshcd_read_string_desc() Bean Huo
2025-10-01 10:03 ` Avri Altman
2025-10-02 4:31 ` Bean Huo
2025-10-01 19:43 ` Bart Van Assche
2025-10-01 6:08 ` [PATCH v2 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver for UFS devices Bean Huo
2025-10-01 7:50 ` Jens Wiklander
2025-10-02 13:37 ` Bean Huo
2025-10-08 15:07 ` Bean Huo
2025-10-13 8:21 ` Jens Wiklander
2025-10-13 12:04 ` Bean Huo
2025-10-13 12:22 ` Jens Wiklander
2025-10-13 15:42 ` Bean Huo [this message]
2025-10-13 15:53 ` Jens Wiklander
2025-10-23 11:32 ` Bean Huo
2025-10-01 10:06 ` Avri Altman
2025-10-02 13:19 ` Bean Huo
2025-10-08 11:47 ` Bean Huo
2025-10-08 12:16 ` Avri Altman
2025-10-01 19:51 ` Bart Van Assche
2025-10-02 13:38 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97c39c0cdb6b96d791fe05f8e5496a502a7e6ac6.camel@iokpp.de \
--to=beanhuo@iokpp.de \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=can.guo@oss.qualcomm.com \
--cc=jejb@linux.ibm.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).