From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C79A18628F; Tue, 7 Jan 2025 17:58:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736272717; cv=none; b=F63MWEyiEaXWbvQsijSVvK0WMSTVxMnv31yVgGrAPSlOoMF0NhXIPJS7wXtLBDKc0ofa1ME6Wpw4Tq8sSnIO5aC9Htpi+jPo8kA6cGPRH2I0F3P6FTA64mkZI6HUxDxVhSK7sYtiIcXCLfZuUQ8UHLRD1vMXXan3wMGbJD4GDhg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736272717; c=relaxed/simple; bh=WV+TLZuDtrq0vN0L2SGNhb5nPcib4hM5tam8yfuu2ms=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h8FZyc1COUBub+QdKMQmYeIFa5eZ/DtiPH41bRU7jsXYe6BAqPfQ2nUw/DSoAhY8Bez6bQ6RNx4JB9vxl8DjUNtXXKMEMvxqEhSikGCykbPz6jjJ74zGinKvrTq30chkUYvSH3f2D6o3oJXy0rd0Nk6U7G1OUezqZUh5IT9ArNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=XTXK1PDW; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="XTXK1PDW" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 507ElJTT027462; Tue, 7 Jan 2025 17:58:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=WV+TLZ uDtrq0vN0L2SGNhb5nPcib4hM5tam8yfuu2ms=; b=XTXK1PDWfRe2ml0glTtfRb OUU4sxcny5hpBhBRM+oFVlOyF9PVrk5FAz56WDVVj+n3krjbgWZzKx8vhgryAdfr LBWQW4eS16og/TueLOMC08LfvR0RBlT4XQ4ltdA8hs49g9lDqcPajQBVUD6W1+Sw 2358ezzTorjMRnljFZ1jmNMA69A0EMEq3Y7qLNAscwpkVXoz0HksKtHZ71EMnq6E t9rlePeOCIRmtwFLhy3SjhAVvcyXzhTksapKwjpGfkvrjCi8s1fUMHOeJtmlvZdA zvYSm2fPV6prDVNGj8K4P+S7LB+QG+q3TmVNZ820S+b953mJgyIiuYLd9AqCHRYQ == Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 440vrjbqs1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 17:58:21 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 507HF41Q015903; Tue, 7 Jan 2025 17:58:20 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43ygtkumpp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 17:58:20 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 507HwJn222217344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Jan 2025 17:58:19 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 943AF58052; Tue, 7 Jan 2025 17:58:19 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A443C5805E; Tue, 7 Jan 2025 17:58:16 +0000 (GMT) Received: from [9.171.94.59] (unknown [9.171.94.59]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 7 Jan 2025 17:58:16 +0000 (GMT) Message-ID: <9875e768-1506-4ed1-8d02-3cf6e86d0c8d@linux.ibm.com> Date: Tue, 7 Jan 2025 23:28:15 +0530 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/8] block: add a queue_limits_commit_update_frozen helper To: Christoph Hellwig , Jens Axboe Cc: Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, nbd@other.debian.org, linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net References: <20250107063120.1011593-1-hch@lst.de> <20250107063120.1011593-3-hch@lst.de> Content-Language: en-US From: Nilay Shroff In-Reply-To: <20250107063120.1011593-3-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 2jFm_4JPVrYZ5aZE8bzYB-U78GoWq2e2 X-Proofpoint-ORIG-GUID: 2jFm_4JPVrYZ5aZE8bzYB-U78GoWq2e2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 adultscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=714 priorityscore=1501 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501070146 Looks good to me. Reviewed-by: Nilay Shroff