From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "andersson@kernel.org" <andersson@kernel.org>,
"bvanassche@acm.org" <bvanassche@acm.org>
Cc: "neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
"quic_nitirawa@quicinc.com" <quic_nitirawa@quicinc.com>,
"James.Bottomley@hansenpartnership.com"
<James.Bottomley@hansenpartnership.com>,
"chullee@google.com" <chullee@google.com>,
"tanghuan@vivo.com" <tanghuan@vivo.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"ebiggers@kernel.org" <ebiggers@kernel.org>,
"gwendal@chromium.org" <gwendal@chromium.org>,
"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
"huobean@gmail.com" <huobean@gmail.com>,
"mani@kernel.org" <mani@kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"liu.song13@zte.com.cn" <liu.song13@zte.com.cn>,
"quic_cang@quicinc.com" <quic_cang@quicinc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH 2/2] ufs: core: Really fix the code for updating the "hid" attribute group
Date: Tue, 28 Oct 2025 12:47:58 +0000 [thread overview]
Message-ID: <98c45a4b9a409d0fb187bc5228076d088650555c.camel@mediatek.com> (raw)
In-Reply-To: <fysnm3cpnz6ipqw4tbw2jh3rvxqjzgabmz2oppccjus3gv2sab@oi6dz4o4zkw2>
On Mon, 2025-10-27 at 22:03 -0500, Bjorn Andersson wrote:
>
>
> I don't fancy the spirit of this fix. The device driver should be
> designed such that initialization happens in a controlled manner, and
> we
> should not have to rely on conditionals sprinkled across the driver
> to
> seemingly get the result we expect (and as this isn't the first
> attempt,
> are we sure you got whacked all the moles now?).
>
Agreed, ensuring the correct flow is better than using some
tricky protection to solve racing issues.
Previously, I asked about fixing the flow:
"Would it be better to ensure that ufshcd_async_scan completes before
invoking ufs_sysfs_add_nodes?"
The answer I got was:
"That would make the sysfs attributes unavailable if the LUN scan
hangs."
But if the LUN scan hangs, shouldn’t we just address the LUN scan hang
issue directly?
Otherwise, the system wouldn’t be able to boot anyway.
Anyway, this patch should be able to fix the warning, although it is a
bit tricky.
next prev parent reply other threads:[~2025-10-28 12:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 17:09 [PATCH 0/2] Two additional UFS fixes for this rc cycle Bart Van Assche
2025-10-27 17:09 ` [PATCH 1/2] ufs: core: Change the ufs_sysfs_{add,remove}_nodes() argument type Bart Van Assche
2025-10-27 17:09 ` [PATCH 2/2] ufs: core: Really fix the code for updating the "hid" attribute group Bart Van Assche
2025-10-28 3:03 ` Bjorn Andersson
2025-10-28 12:47 ` Peter Wang (王信友) [this message]
2025-10-28 13:33 ` Bart Van Assche
2025-10-28 13:57 ` Bart Van Assche
2025-10-28 14:50 ` Bjorn Andersson
2025-10-28 20:21 ` Bart Van Assche
2025-10-28 9:51 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98c45a4b9a409d0fb187bc5228076d088650555c.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=adrian.hunter@intel.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=chullee@google.com \
--cc=ebiggers@kernel.org \
--cc=gwendal@chromium.org \
--cc=huobean@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=liu.song13@zte.com.cn \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=tanghuan@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox