From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] scsi_dh_alua: suppress errors from unsupported devices
Date: Mon, 7 Aug 2017 08:07:10 +0200 [thread overview]
Message-ID: <990a352f-e21b-4d71-288e-9165b9ce8dd3@suse.de> (raw)
In-Reply-To: <20170805113523.GC16313@lst.de>
On 08/05/2017 01:35 PM, Christoph Hellwig wrote:
>> error = scsi_dh_add_device(sdev);
>> - if (error)
>> - /*
>> - * device_handler is optional, so any error can be ignored
>> - */
>> - sdev_printk(KERN_INFO, sdev,
>> - "failed to add device handler: %d\n", error);
>> + /* device_handler is optional, so any error can be ignored */
>
> In that case it should return void.
>
Okay, will be updating the patch.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
prev parent reply other threads:[~2017-08-07 6:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 6:37 [PATCH] scsi_dh_alua: suppress errors from unsupported devices Hannes Reinecke
2017-08-04 7:11 ` Johannes Thumshirn
2017-08-04 15:56 ` Bart Van Assche
2017-08-05 11:35 ` Christoph Hellwig
2017-08-07 6:07 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=990a352f-e21b-4d71-288e-9165b9ce8dd3@suse.de \
--to=hare@suse.de \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox