Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Igor Pylypiv <ipylypiv@google.com>
Cc: linux-ide@vger.kernel.org, Niklas Cassel <cassel@kernel.org>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	John Garry <john.g.garry@oracle.com>,
	Jason Yan <yanaijie@huawei.com>
Subject: Re: [PATCH v5 0/2] fixup handling of timeouts with deferred QCs
Date: Sat, 18 Jul 2026 10:04:08 +0900	[thread overview]
Message-ID: <99e6d5af-c680-42bb-8926-213d76ce56fa@kernel.org> (raw)
In-Reply-To: <alpnLgBhz0pb9wDv@google.com>

On 7/18/26 02:32, Igor Pylypiv wrote:
> On Thu, Jul 16, 2026 at 05:38:45PM +0900, Damien Le Moal wrote:
>> This patch series fixes libata and libsas to correctly handles deferred
>> queued commands in case of a timeout error, to avoid excessive delays in
>> waking up the scsi EH task.
>>
>> Igor,
>>
>> My apologies for the churn, but please retest !
>> Also, I added your Signed-off-by on patch 2 since half of it is yours.
> 
> Thank you, Damien! Test resuls look good.
> 
> I saw you are planning to send v6, I'll wait for it and will retest again.

I am planning to, because Sashiko keeps finding races or uncorevered cases that
can leave deferred QCs stranded and unprocessed. I am still digging into that
because I am not convinced yet that what Sashiko finds is possible or not :)

> 
> Tested-by: Igor Pylypiv <ipylypiv@google.com>

Thanks. Please keep testing!

-- 
Damien Le Moal
Western Digital Research

      reply	other threads:[~2026-07-18  1:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16  8:38 [PATCH v5 0/2] fixup handling of timeouts with deferred QCs Damien Le Moal
2026-07-16  8:38 ` [PATCH v5 1/2] ata: libata-scsi: terminate deferred commands on time out Damien Le Moal
2026-07-16 13:46   ` Hannes Reinecke
2026-07-16  8:38 ` [PATCH v5 2/2] scsi: libsas: " Damien Le Moal
2026-07-16 10:57   ` John Garry
2026-07-16 13:47   ` Hannes Reinecke
2026-07-17 17:32 ` [PATCH v5 0/2] fixup handling of timeouts with deferred QCs Igor Pylypiv
2026-07-18  1:04   ` Damien Le Moal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99e6d5af-c680-42bb-8926-213d76ce56fa@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cassel@kernel.org \
    --cc=ipylypiv@google.com \
    --cc=john.g.garry@oracle.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox