Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

Dave Jones
2005-08-04T17:39:08Z

On Thu, Aug 04, 2005 at 07:11:38PM +0200, Rolf Eike Beer wrote:
> >It's pointless to fix this, without fixing also CpqTsGetSFQEntry()
> At least half of the file should be rewritten.

Just half ? You're such an optimist :-)

> > > No, ulDestPtr ist ULONG* so we increase it by sizeof(ULONG)*16 which is
> > > 64.
> >Duh, yes. That is broken on 64-bit however, where it will advance 128 bytes
> >instead of 64 bytes.
>
> ULONG is defined to __u32 in some of the cpq* headers.

Ewwwww.
Ok, definitly time to stop reading.

Dave