From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
Daejun Park <daejun7.park@samsung.com>,
Kanchan Joshi <joshi.k@samsung.com>,
Douglas Gilbert <dgilbert@interlog.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH v4 15/15] scsi_debug: Maintain write statistics per group number
Date: Tue, 21 Nov 2023 11:25:08 -0800 [thread overview]
Message-ID: <9abebf27-a3db-42bb-b0e5-fb4ff6689c14@acm.org> (raw)
In-Reply-To: <20231114214132.1486867-16-bvanassche@acm.org>
On 11/14/23 13:41, Bart Van Assche wrote:
> +static ssize_t group_number_stats_store(struct device_driver *ddp,
> + const char *buf,
> + size_t count)
> +{
> + int i;
> +
> + for (i = 0; i < ARRAY_SIZE(writes_by_group_number); i++)
> + atomic_long_set(&writes_by_group_number[i], 0);
> +
> + return 0;
> +}
There is a bug in this patch: "return 0" above should be changed into
"return count". I will repost this patch series.
Bart.
prev parent reply other threads:[~2023-11-21 19:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 21:40 [PATCH v4 00/15] Pass data lifetime information to SCSI disk devices Bart Van Assche
2023-11-14 21:40 ` [PATCH v4 01/15] fs: Rename the kernel-internal data lifetime constants Bart Van Assche
2023-11-20 7:19 ` Kanchan Joshi
2023-11-27 7:08 ` Christoph Hellwig
2023-11-27 8:45 ` Kanchan Joshi
2023-11-27 9:29 ` Christoph Hellwig
2023-11-27 19:00 ` Bart Van Assche
2023-11-14 21:40 ` [PATCH v4 02/15] fs: Move enum rw_hint into a new header file Bart Van Assche
2023-11-14 21:40 ` [PATCH v4 03/15] block: Restore data lifetime support in struct bio and struct request Bart Van Assche
2023-11-14 21:40 ` [PATCH v4 04/15] fs: Restore write hint support Bart Van Assche
2023-11-14 21:41 ` [PATCH v4 05/15] fs/f2fs: Restore data lifetime support Bart Van Assche
2023-11-20 7:36 ` Kanchan Joshi
2023-11-20 17:53 ` Bart Van Assche
2023-11-14 21:41 ` [PATCH v4 06/15] scsi: core: Query the Block Limits Extension VPD page Bart Van Assche
2023-11-14 21:41 ` [PATCH v4 07/15] scsi_proto: Add structures and constants related to I/O groups and streams Bart Van Assche
2023-11-14 21:41 ` [PATCH v4 08/15] sd: Translate data lifetime information Bart Van Assche
2023-11-14 21:41 ` [PATCH v4 09/15] scsi_debug: Reduce code duplication Bart Van Assche
2023-11-14 21:41 ` [PATCH v4 10/15] scsi_debug: Support the block limits extension VPD page Bart Van Assche
2023-11-14 21:41 ` [PATCH v4 11/15] scsi_debug: Rework page code error handling Bart Van Assche
2023-11-14 21:41 ` [PATCH v4 12/15] scsi_debug: Rework subpage " Bart Van Assche
2023-11-14 21:41 ` [PATCH v4 13/15] scsi_debug: Implement the IO Advice Hints Grouping mode page Bart Van Assche
2023-11-14 21:41 ` [PATCH v4 14/15] scsi_debug: Implement GET STREAM STATUS Bart Van Assche
2023-11-14 21:41 ` [PATCH v4 15/15] scsi_debug: Maintain write statistics per group number Bart Van Assche
2023-11-21 19:25 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9abebf27-a3db-42bb-b0e5-fb4ff6689c14@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=daejun7.park@samsung.com \
--cc=dgilbert@interlog.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox