From: Bart Van Assche <bvanassche@acm.org>
To: HOYOUNG SEO <hy50.seo@samsung.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, beanhuo@micron.com,
kwangwon.min@samsung.com, kwmad.kim@samsung.com,
cpgs@samsung.com, h10.kim@samsung.com
Subject: Re: [PATCH v1] scsi: ufs: core: Introduce quirk to check UTP error
Date: Mon, 29 Sep 2025 09:49:09 -0700 [thread overview]
Message-ID: <9b60d18d-d590-4fc1-8aff-e8a0fcebd79b@acm.org> (raw)
In-Reply-To: <20250929105801.428105-1-hy50.seo@samsung.com>
On 9/29/25 3:58 AM, HOYOUNG SEO wrote:
> + /*
> + * This quirk indicated that report the error when UTP error occurs.
> + * Enable this quirk will the error handler allows the ufs to be reocvery.
> + */
> + UFSHCD_QUIRK_UTP_ERROR = 1 << 26,
Quirks should only be introduced for behavior that differs between host
controllers. I don't see why the behavior introduced by this patch
should only be enabled for some UFS host controllers and not for all UFS
host controllers. Please remove "UFSHCD_QUIRK_UTP_ERROR" from this patch
such that UTP errors trigger UFS error handling for all UFS host
controllers.
Thanks,
Bart.
prev parent reply other threads:[~2025-09-29 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250929105936epcas2p1308a10b1ab51c5b543ea246bc3165fe4@epcas2p1.samsung.com>
2025-09-29 10:58 ` [PATCH v1] scsi: ufs: core: Introduce quirk to check UTP error HOYOUNG SEO
2025-09-29 16:49 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b60d18d-d590-4fc1-8aff-e8a0fcebd79b@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cpgs@samsung.com \
--cc=h10.kim@samsung.com \
--cc=hy50.seo@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=kwangwon.min@samsung.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).