From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04224149C6F for ; Fri, 26 Jun 2026 21:52:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782510758; cv=none; b=RJqAcsB/dfvZ1zbxzAFxXjCKsvw0c2kGkzar9DURsywvLuT4AqXHp9L8tpE90gksrRfNEOeyy1UNje/+pW3XtccBij2YJiImwN1o8yixqka6SbPrTUmM2xBiKYH7BxEK7xFtmZqhg9yduJGNQAOGByhpLHA94vntpJLvapa7fnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782510758; c=relaxed/simple; bh=9Oeta3wxqTHs1QJ++9ccfGwG1uukfM+GxOgFVvoIees=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LbYjl9Z7+WxyxUU0jP2ELTPjxqTa6GzBOWPrjaOtvpEDfO2iPaaKSN/lDoRzveZZ0CO5CYKmheonfjGYex+ulnKb7jODrm51+4+k1YwCDNuKKGdfXTe+HjMpDxj0bftf8/0OofxpP0hLCIQZ2I+CI3tga0nsmLb4/2iNAs4nTwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a8RocOcG; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a8RocOcG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70C601F00A3A; Fri, 26 Jun 2026 21:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782510757; bh=ALjPKz2lMu7o7U4IUPXJUeyPR9n3MgYSnJRSgBg4HKI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=a8RocOcGS+WucKVj2En+gpaOfsge+ny0zvhrlCQXPvazBtZ/k6YOKZxyEt4J1QqY0 oN6kvt3C42f9qM87SscVsU42cmoZ2wpKi+oWOdjKGkOt2sG+cpr/Tc21YyLGwitmsd Tx5dFkvC4yUpLYGgzY4EXfNmCoHtBxw+X9AFmKgYHvmsJF73/Y/mG6tJnyjLhmQBDS d9sVCKF5Q/PGuB0BBAqN9PAnK63bQKkqmX7eNHhXhAg3A5uC1MwGieLK5p2wWGYudX 38KsBR7Ucj7pZ1EOmOeaK77OTy0KXOYDUFmrGfDO524zZUbFh8VlwAeq5/DIK8+yFH mLkTCTLVPFXuQ== Message-ID: <9bb57458-21e1-4e20-8d1f-6b728813f2e3@kernel.org> Date: Sat, 27 Jun 2026 06:52:34 +0900 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] scsi: sd: fix error handling in sd_probe() after large pool creation failure To: Yang Xiuwei , martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com Cc: hare@suse.de, tom.leiming@gmail.com, p.raghav@samsung.com, sw.prabhu6@gmail.com, linux-scsi@vger.kernel.org References: <20260623100159.4018066-1-yangxiuwei@kylinos.cn> <20260623100159.4018066-2-yangxiuwei@kylinos.cn> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20260623100159.4018066-2-yangxiuwei@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/23/26 19:01, Yang Xiuwei wrote: > After device_add(&sdkp->disk_dev) succeeds, sd_large_pool_create() > failure must unregister disk_dev and let scsi_disk_release() free > sdkp. Going through out_free_index kfree()s an already registered > device and leaks the sysfs entry. > > Fixes: 7179e626b76e ("scsi: sd: Enable sector size > PAGE_SIZE in SCSI sd driver") > Signed-off-by: Yang Xiuwei Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research