From mboxrd@z Thu Jan 1 00:00:00 1970 From: merez@codeaurora.org Subject: Re: [PATCH 1/5] scsi: ufs: move the ufshcd_hba_stop to ufshcd.c Date: Thu, 2 May 2013 11:49:30 -0700 Message-ID: <9cecae517114529824387aac48cf94f9.squirrel@www.codeaurora.org> References: <1366812872-26331-1-git-send-email-sthumma@codeaurora.org> <001e01ce4105$ab4e2430$01ea6c90$%jun@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:64289 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761925Ab3EBSta (ORCPT ); Thu, 2 May 2013 14:49:30 -0400 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Santosh Y Cc: Seungwon Jeon , linux-scsi@vger.kernel.org, Vinayak Holikatti , "James E.J. Bottomley" Hi, Can you please rebase the next version on top of the following patches which are the next candidates for merge? Vinayak Holikatti (2): ufs: Add Platform glue driver for ufshcd ufs: Correct the expected data transfersize Dolev Raviv (1): scsi: ufs: add support for query requests Thanks, Maya > On Wed, Apr 24, 2013 at 9:36 PM, Seungwon Jeon > wrote: >> Move the ufshcd_hba_stop from header file. >> >> Signed-off-by: Seungwon Jeon >> --- >> drivers/scsi/ufs/ufshcd.c | 9 +++++++++ >> drivers/scsi/ufs/ufshcd.h | 9 --------- >> 2 files changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c >> index 60fd40c..41b9639 100644 >> --- a/drivers/scsi/ufs/ufshcd.c >> +++ b/drivers/scsi/ufs/ufshcd.c >> @@ -285,6 +285,15 @@ static inline void ufshcd_hba_start(struct ufs_hba >> *hba) >> } >> >> /** >> + * ufshcd_hba_stop - Send controller to reset state >> + * @hba: per adapter instance >> + */ >> +static inline void ufshcd_hba_stop(struct ufs_hba *hba) >> +{ >> + writel(CONTROLLER_DISABLE, (hba->mmio_base + >> REG_CONTROLLER_ENABLE)); >> +} >> + >> +/** >> * ufshcd_is_hba_active - Get controller state >> * @hba: per adapter instance >> * >> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h >> index 6b99a42..1680394 100644 >> --- a/drivers/scsi/ufs/ufshcd.h >> +++ b/drivers/scsi/ufs/ufshcd.h >> @@ -190,13 +190,4 @@ int ufshcd_init(struct device *, struct ufs_hba ** >> , void __iomem * , >> unsigned int); >> void ufshcd_remove(struct ufs_hba *); >> >> -/** >> - * ufshcd_hba_stop - Send controller to reset state >> - * @hba: per adapter instance >> - */ >> -static inline void ufshcd_hba_stop(struct ufs_hba *hba) >> -{ >> - writel(CONTROLLER_DISABLE, (hba->mmio_base + >> REG_CONTROLLER_ENABLE)); >> -} >> - >> #endif /* End of Header */ >> -- >> 1.7.0.4 >> >> > > The patch doesn't apply due to the character set. > > "fatal: cannot convert from ks_c_5601-1987 to UTF-8" > > > -- > ~Santosh > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Maya Erez QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation