From: Ziqi Chen <quic_ziqichen@quicinc.com>
To: Bart Van Assche <bvanassche@acm.org>, <quic_asutoshd@quicinc.com>,
<quic_cang@quicinc.com>, <mani@kernel.org>,
<stanley.chu@mediatek.com>, <adrian.hunter@intel.com>,
<beanhuo@micron.com>, <avri.altman@wdc.com>,
<junwoo80.lee@samsung.com>, <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:TRACING" <linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] scsi: ufs: core: Add trace event for MCQ
Date: Fri, 10 Mar 2023 12:19:59 +0800 [thread overview]
Message-ID: <9d54e732-75e6-6912-750b-2c4238d618bb@quicinc.com> (raw)
In-Reply-To: <99f2ea8e-e543-fc14-91d7-0e7e29d2f381@acm.org>
On 3/9/2023 11:45 PM, Bart Van Assche wrote:
> On 3/8/23 18:44, Ziqi Chen wrote:
>> Thanks for you suggestion. But the member hwq->id is an Unsigned
>> integer. if you want to identify SDB mode and MCQ mode, using "0" is
>> enough, Or how about add string such as below?
>>
>> ufshcd_command: MCQ: complete_rsp: 1d84000.ufshc: tag: 14, DB: 0x0,
>> size: 32768, IS: 0, LBA: 5979448,opcode: 0x2a (WRITE_10),group_id:
>> 0x0, hqid: 2
>
> Hi Ziqi,
>
> Since 0 is a valid queue ID using 0 to identify the legacy command
> submission mechanism is ambiguous.
>
> Thanks,
>
> Bart.
OK, let me convert hwq id to int from ftrace side.
Best Regards,
Ziqi
prev parent reply other threads:[~2023-03-10 4:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 9:35 [PATCH v4] scsi: ufs: core: Add trace event for MCQ Ziqi Chen
2023-03-03 18:01 ` Bart Van Assche
[not found] ` <f80fd91b-3a03-5c38-72c0-cd5c3edb33b8@quicinc.com>
2023-03-07 15:47 ` Bart Van Assche
2023-03-09 2:44 ` Ziqi Chen
2023-03-09 15:45 ` Bart Van Assche
2023-03-10 4:19 ` Ziqi Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d54e732-75e6-6912-750b-2c4238d618bb@quicinc.com \
--to=quic_ziqichen@quicinc.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=junwoo80.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mhiramat@kernel.org \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=rostedt@goodmis.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox