Re: [PATCH v2 1/1] scsi: core: Fix error handler encryption support

[Bart Van Assche <bvanassche@acm.org>]

On 12/2/25 9:38 PM, Christoph Hellwig wrote:
> On Wed, Dec 03, 2025 at 07:33:08AM +0000, Po-Wen Kao wrote:
>> From: Brian Kao <powenkao@google.com>
>>
>> Some low-level drivers (LLD) access block layer crypto fields, such as
>> rq->crypt_keyslot and rq->crypt_ctx within `struct request`, to
>> configure hardware for inline encryption.
> 
> So don't do that except for commands that can actually be encrypted,
> i.e. those that have non-zero payload size.  I think you really want
> to fix this in the driver.

That would make it impossible to submit SCSI commands from the SCSI
error handler that read data, e.g. to check that the medium is still
readable. I think that the approach of this patch is better than
requiring that every SCSI LLD driver that supports inline encryption
only sets up inline encryption for commands that have a non-zero
payload size.

Thanks,

Bart.