From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8440355F2F; Fri, 27 Feb 2026 19:31:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772220695; cv=none; b=ftEG2h25dHmusrhq8+9Yhbsy/Ei+r1R8BfBGT44C3CykeELVrbgabo0MLzOH1HE7LYVcEzx0+FIEkeyGVFpBrwWQJtfawej9EKdg0gRWz7ArbWnDgCBu3Xb5RPIH2Ce0N0lEQEvNH9QiItG4EbhY3Lvudph8BaodDuvtaCkO2x4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772220695; c=relaxed/simple; bh=gcUwh0qPFw5GdQRQKa/RuurbIQBpHHkCJD7079f3Oq8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PPWeYaWYUQJmmIOaVgk1HFPPbQvjEz85L6UDYi+ehLpMN0wfq4kHltyZgDzNUQ1V5VTl01SlO9ZJW1tpFpp++V0jS/e4gfUacYpNUmqt647beWSFXvPTbSpHEFDuQSd9Lg2eXPpPnJ/eoLhhOWnkTnPGQkU7a+QKC+uOXI57XM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=BId/d7GQ; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="BId/d7GQ" Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4fMz391N4VzlfgS0; Fri, 27 Feb 2026 19:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1772220680; x=1774812681; bh=KMd0qDawP3LtnNVvdXu0EXZ0 bVclYbc/s4g1QlOu6ME=; b=BId/d7GQJieiPJXeB15F3xR7jTlrDEn6whU05ToR lVQj5w9r6atacQ/ykKhH8hZNvihgIKl5O1jVgbWVBbNpWMWiCmqg4ufzhpGKNtET OlazOYWfWmhvjn/CYoIx37rTUIhKoCEFSMkxWTsrqAXMok9hNkwnWluCFCOecQEf NrcduviqoDilLdkeXcUWJMSl6oRgkYTxWfrje0243cgJjlT5r+GXPliCRXE3h7D4 L+1XR9167R4wFe2XJ8jP1fzl1XyC4c4WmtjG+FEIdMyPK3SuQvRK/SR956bRoS4s ecSNPm+/sCSSxJvwJ3yrWoLLIDSDs+7KoxFhufzWgu/zqA== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id F69mF0ONa_jO; Fri, 27 Feb 2026 19:31:20 +0000 (UTC) Received: from [100.119.48.131] (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4fMz2n0mQrzlfgRw; Fri, 27 Feb 2026 19:31:12 +0000 (UTC) Message-ID: <9d975881-7570-495d-94ea-085e2012a9af@acm.org> Date: Fri, 27 Feb 2026 11:31:11 -0800 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/11] scsi: ufs: core: Introduce a new ufshcd vops negotiate_pwr_mode() To: Can Guo , avri.altman@wdc.com, beanhuo@micron.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Sai Krishna Potthuri , Ajay Neeli , Peter Griffin , Krzysztof Kozlowski , Peter Wang , Chaotian Jing , Stanley Jhu , Manivannan Sadhasivam , Orson Zhai , Baolin Wang , Chunyan Zhang , Matthias Brugger , AngeloGioacchino Del Regno , "Bao D. Nguyen" , Adrian Hunter , Archana Patni , open list , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." References: <20260227160809.2620598-1-can.guo@oss.qualcomm.com> <20260227160809.2620598-2-can.guo@oss.qualcomm.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20260227160809.2620598-2-can.guo@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/27/26 8:07 AM, Can Guo wrote: > Before power mode change to a target power mode, TX Equalzation Training "Equalzation" -> "Equalization" > (EQTR) needs be done for that target power mode. In addition, before TX > EQTR we need to change the power mode to HS-G1. These cannot happen > before the vops pwr_change_notify(PRE_CHANGE) because we don't know the > negotiated target power mode yet. It is neither approprite if all these > happen post the vops pwr_change_notify(PRE_CHANGE) as we are going to > change the power mode to HS-G1 for TX EQTR. approprite -> appropriate Additionally, if "neither" occurs in a sentence, "nor" should occur in the same sentence. I don't see "nor" in the above sentence? > Introduce a new ufshcd vops negotiate_pwr_mode(), so that TX EQTR can be > done after vops negotiate_pwr_mode() and before vops pwr_change_notify(). This patch does much more than only introducing a new vendor operation. Please make sure the patch description is complete. > - return -ENOTSUPP; > + return -EOPNOTSUPP; Why has ENOTSUPP been changed into EOPNOTSUPP? > -static int ufshcd_change_power_mode(struct ufs_hba *hba, > - struct ufs_pa_layer_attr *pwr_mode) > +static int __ufshcd_change_power_mode(struct ufs_hba *hba, > + struct ufs_pa_layer_attr *pwr_mode) > { > int ret; The double underscore prefix is typically used in the Linux kernel to indicate that the caller holds a lock. That is not the case here. Please choose another name for this function, e.g. ufshcd_dme_change_power_mode(). Thanks, Bart.