From: "André Draszik" <andre.draszik@linaro.org>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Peter Wang <peter.wang@mediatek.com>,
Ziqi Chen <quic_ziqichen@quicinc.com>,
Can Guo <quic_cang@quicinc.com>,
Manivannan Sadhasivam <mani@kernel.org>,
"Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
Bean Huo <beanhuo@micron.com>
Subject: Re: [PATCH] ufs: core: Fix single doorbell mode support
Date: Sat, 15 Nov 2025 16:10:02 +0000 [thread overview]
Message-ID: <9de4a893e2c3cf8c5d8337589b02b3eb883afeef.camel@linaro.org> (raw)
In-Reply-To: <20251114193406.3097237-1-bvanassche@acm.org>
On Fri, 2025-11-14 at 11:34 -0800, Bart Van Assche wrote:
> Commit 22089c218037 ("scsi: ufs: core: Optimize the hot path")
> accidentally broke support for the legacy single doorbell mode.
> The tag_set.shared_tags pointer is only != NULL if shared tag support is
> enabled. The UFS driver only enables shared tag support in MCQ mode.
>
> Fix this by handling legacy and MCQ modes differently in
> ufshcd_tag_to_cmd().
>
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Closes: https://lore.kernel.org/linux-scsi/c988a6dd-588d-4dbc-ab83-bbee17f2a686@samsung.com/
> Reported-by: André Draszik <andre.draszik@linaro.org>
> Closes: https://lore.kernel.org/linux-scsi/83ffbceb9e66b2a3b6096231551d969034ed8a74.camel@linaro.org/
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Fixes: 22089c218037 ("scsi: ufs: core: Optimize the hot path")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/ufs/core/ufshcd-priv.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
This fixes it for me on Pixel 6, too.
Tested-by: André Draszik <andre.draszik@linaro.org>
Thanks Bart for the quick fix!
next prev parent reply other threads:[~2025-11-15 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 19:34 [PATCH] ufs: core: Fix single doorbell mode support Bart Van Assche
2025-11-15 16:10 ` André Draszik [this message]
2025-11-19 17:04 ` Martin K. Petersen
2025-11-29 3:30 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9de4a893e2c3cf8c5d8337589b02b3eb883afeef.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox