Re: [PATCH v16 09/26] mq-deadline: Remove a local variable

Bart Van Assche
2024-11-19T21:12:01Z

On 11/18/24 11:38 PM, Damien Le Moal wrote:
> On 11/19/24 09:27, Bart Van Assche wrote:
>> Since commit fde02699c242 ("block: mq-deadline: Remove support for zone
>> write locking"), the local variable 'insert_before' is assigned once and
>> is used once. Hence remove this local variable.
>>
>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>
> Looks good.
>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
>
> This patch can be sent separately from this series I think. It does not really
> belong here, no ?

Thanks for the review. There is another mq-deadline change in this
series that depends on this change ("blk-mq: Restore the zoned write
order when requeuing"). This is why I included this patch in this
series.

Bart.