Re: [PATCH v16 26/26] scsi: ufs: Inform the block layer about write ordering

Can Guo
2024-11-23T00:35:10Z

On 11/23/2024 2:20 AM, Bart Van Assche wrote:
> On 11/21/24 6:58 PM, Can Guo wrote:
>> So, in MCQ mode, we are re-directing all zoned writes to one HW queue
>> to preserve the write order, is my understanding correct?
> That's somewhat but not entirely correct. As one can see in patch 20/26,
> the software queue (and hence also the hardware queue) that was selected
> for zoned writes is unselected after all pending zoned writes for a
> given zone have completed:
>
> +    if (refcount_read(&zwplug->ref) == 2)
> +        zwplug->swq_cpu = -1;
>
> So the next time a write bio or write request is submitted a different
> queue may be selected.

Understood, thanks for explaining.

Reviewed-by: Can Guo <quic_cang@quicinc.com>

>
> Thanks,
>
> Bart.