Re: [PATCH v7 08/19] scsi: detect support for command duration limits

[Damien Le Moal <dlemoal@kernel.org>]

On 7/10/25 5:41 PM, Friedrich Weber wrote:
> Hi Damien,
> 
> On 09/06/2025 14:24, Damien Le Moal wrote:
>> On 6/3/25 20:28, Friedrich Weber wrote:
>>>>> They provided controller information via `sas3ircu` and `storcli`:
>>>>>
>>>>> sas3ircu:
>>>>>
>>>>>   Controller type                         : SAS3008
>>>>>   BIOS version                            : 8.37.00.00
>>>>>   Firmware version                        : 16.00.16.00
>>>>
>>>> Is this the latest available FW for this HBA ? (see below)
>>>
>>> It seems 16.00.16.00 is even newer than the latest version available on
>>> the Broadcom website, which is a bit strange -- I only found [1] there
>>> which has an older 16.00.14.00 (3008_FW_PH16.00.14.00.rar).
>>
>> So this is an old/now EOL 9300 series HBA, right ? Or is this a 3008 controller
>> chip as part of the server motherboard (e.g. a supermicro HBA ?)
>> Looking at the Broadcom support page for legacy products, the latest FW version
>> seems to be 16.00.10.00.
> 
> According to the user it is not part of a server motherboard but a
> "proper" PCIe Broadcom SAS 9300-8i HBA.

This is an old HBA EOL HBA that has no FW update. So we will need to quirk it
to avoid the CDL probing with MAINTENANCE IN command as that seems to be the issue.

> Yeah, I agree checking the latest firmware makes sense for these,
> unfortunately they are currently in use so the user cannot test with them.
> 
> But we might be able to run some tests with a Supermicro
> AOC-S3816L-L16iT (so Broadcom SAS3816?) soon where the hotplug issue
> apparently also happens. We'll make sure to update to the latest
> firmware and I'll do my best to collect relevant logs. If you can think
> of anything specific we should collect, feel free to let me know.

See above. With such old HBA, there is no FW update.

I think we can safely ignore CDL support for the mpt3sas driver since the HBAs
controlled with this driver (9300, 9400 and 9500) do not support CDL at all.

Will try to cook something.

> Thanks for looking into this, it is definitely a strange problem.
> 
> Considering these drives don't support CDL anyway: Do you think it would
> be possible to provide an "escape hatch" to disable only the CDL checks
> (a module parameter?) so hotplug can work for the user again for their
> device? If I see correctly, disabling just the CDL checks is not
> possible (without recompiling the kernel) -- scsi_mod.dev_flags can be
> used to disable RSOC, but I guess that has other unintended consequences
> too, so a more "targeted" escape hatch would be nice.

No need to quirk the drives since the HBAs themselves do not support CDL at
all. Let me see how to do it. Basically, we need to prevent the call to
scsi_cdl_check() if the scsi host is from mpt3sas...


-- 
Damien Le Moal
Western Digital Research