From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B331E22839A for ; Mon, 7 Apr 2025 08:43:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744015432; cv=none; b=Yt9yRfsEyV6KN4kmpsiWdTdFdnYN/05iiCFg//6WmvOPerHi+cew+HPprBAL+pV/ansC67ZoxGHvqeALUgGJmehQK+VZKMI9schsRe+jN6wjLfRzGlUxxVqK5IqjcJIapE0iQIBh8WlapboBHM82LWENMr+1Lr7bwfR1Nsnjp6Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744015432; c=relaxed/simple; bh=keeF2gzO1BG5TWSeisN2mF/28JltLtP+6/MPGcZqXK0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ioY9YzXa95J395fMrAf91NfkKU9L8bjljmsplawAt07gTGulQ82l4AXKiV6Kf7FGncP3bF43n8ZfKnwkdZyyz8s8uvyi4uFo1YUkp9DVD9kpcTzm40+JplWfM6HxFzF7piR3wmGx0be8TB54r4CD9l6koJasENuAcu0HUAaKuwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eskuvMgP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eskuvMgP" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5378drYi016239 for ; Mon, 7 Apr 2025 08:43:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3LBZTe8by3wdJUm3j4TfqVrMn6/WCYmbjyVJqI9BVQI=; b=eskuvMgPTq/478q1 aQrcm1nxa4BmpCqiMspO3aan+oaX57dgYk8O3sZaJSJ/GfvuXof7lncClX/UqrLE i7LggPpgmUzsg+cILKjgk6TbgDvXNEzqD/K+hVjjnSxD3LcIZhrta09w6OG/yL7h FeEUUwtyrQepSTHAyZd/zD5ItJVRoPKQ/mpqNnW4nMS6jcr1g+0DFZaOv9hLsSoh 3ViF+iGeWObcIeLR5UJEio7DAHMcJfAUak/5EUgJABMyzlIkwnvvAu+IairodlNd QoYecjWf9Mq1DTw07kU/jroJLWRBOVk/hVnhnJWFUIdWKRB9o8lnV4PD7ZeTzxU2 FSzYag== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45twdgbkwp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 07 Apr 2025 08:43:48 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6e8f9c5af3dso2730876d6.1 for ; Mon, 07 Apr 2025 01:43:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744015428; x=1744620228; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3LBZTe8by3wdJUm3j4TfqVrMn6/WCYmbjyVJqI9BVQI=; b=vP49ptiFTjqJKE52YQlkDt1jTeWU6KAu101zMz8wv2SFFuE/l5OV2A6wRSzBgjt6+j KGefKDygPLcR8MlCYaGVbdEuFig12R6y/lXDdmfhoNWgkaVx9s71SaKMVUglmKE+OjiH HuntufVrdCfUPAN4A+e11Iz2pySfazn01YAD5z2+2CdXsKCwCn8DkD5oGh2odTyBXshU l0LDU8WeS8k9TYcCD++SXkSUUkmj/t46fygjdBZ2DuvCQHUuTe/JHdW+LU3dnhBLhzBL vSyZxcsuEm0yZ1/BHxoOECZKuD26h+ABiF0adDFyNa1xyaYSR1KyBUxEfUEycLaMAUPF xxbw== X-Forwarded-Encrypted: i=1; AJvYcCVL5mw8gwR/aMCRe0OH0N7cL8mL+l1gpqCJOlWmKb46TNROUJxWr0NwH3IFj4yJrZhBykWcz5eLAbla@vger.kernel.org X-Gm-Message-State: AOJu0YxyE5Pk8MqKveTuoY1IvyVx7q+7NWyttiqBxshi/poQrJ4zLDWM nidP3vtvrHoO3uEazGFA9sl7sWH3sCFKtTMTOhmdxJ1drNFs5C/ge5vDJEeHW8o7nXThU8OnIkN 1ClYr6ujPtCIJtFxD3Wlj0idNRw1N7q5pHcsAzZQbUpZNJBcBIv2JtF36R1zt X-Gm-Gg: ASbGncuH7uJH74BULut+vSFOPrRHsep53mdNgeFC0j20It5m+WO3NOJd3E0zkWEEHPz KPlCFThMa6XWQzNhGmpfx6imGn6bMglnAVJR19BynvR2aG8KSv75teeSDrrUWpYLJFpH9kPGPN8 G1i8lrSerULu+xh0sPnAbg7lRWGNHwjAleqvhjXdozlinCfHuQ4xKR8ZDAfw+Wy0r5/4HVqF9b9 uD5EGPuplL4kdPmOiljaYr2fLC3OdlVzwpcG6I/M2VM9FO+FHeiAovOKiRNKPbaSVF7gY6LB04A ZIkPS4nJsuS+U7nABJ5Bdxr+RcY4LXy7EBSMqW0o50RUslRdGiV8okxG0SE7fyOFLn9cbQ== X-Received: by 2002:a05:6214:e8e:b0:6e4:29f8:1e9e with SMTP id 6a1803df08f44-6f00214d08fmr68496686d6.0.1744015427730; Mon, 07 Apr 2025 01:43:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEFebGzNDRB0fY7+hPc7f12BLxECnTU/bMrpcOZJhMDdfXfqIZ/Ci0T8pDYTDUbni8F9lrsXA== X-Received: by 2002:a05:6214:e8e:b0:6e4:29f8:1e9e with SMTP id 6a1803df08f44-6f00214d08fmr68496546d6.0.1744015427351; Mon, 07 Apr 2025 01:43:47 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac7c013f34dsm701813966b.87.2025.04.07.01.43.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Apr 2025 01:43:46 -0700 (PDT) Message-ID: <9eb0b21c-6830-4636-8a92-e174e34d779a@oss.qualcomm.com> Date: Mon, 7 Apr 2025 10:43:43 +0200 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 1/3] soc: qcom: ice: make qcom_ice_program_key() take struct blk_crypto_key To: Eric Biggers , linux-scsi@vger.kernel.org Cc: linux-block@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fscrypt@vger.kernel.org, Bartosz Golaszewski , Gaurav Kashyap , Bjorn Andersson , Dmitry Baryshkov , Jens Axboe , Konrad Dybcio , Manivannan Sadhasivam , Bartosz Golaszewski References: <20250404231533.174419-1-ebiggers@kernel.org> <20250404231533.174419-2-ebiggers@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250404231533.174419-2-ebiggers@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=PJgP+eqC c=1 sm=1 tr=0 ts=67f39044 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=1XWaLZrsAAAA:8 a=COk6AnOGAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=frSOPK2eQqz-eahEfmcA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=TjNXssC_j7lpFel5tvFf:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: lGsNTRCmojC1fXC0skBP5zTmpUF43fMP X-Proofpoint-GUID: lGsNTRCmojC1fXC0skBP5zTmpUF43fMP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-07_02,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 malwarescore=0 spamscore=0 impostorscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504070062 On 4/5/25 1:15 AM, Eric Biggers wrote: > From: Eric Biggers > > qcom_ice_program_key() currently accepts the key as an array of bytes, > algorithm ID, key size enum, and data unit size. However both callers > have a struct blk_crypto_key which contains all that information. Thus > they both have similar code that converts the blk_crypto_key into the > form that qcom_ice_program_key() wants. Once wrapped key support is > added, the key type would need to be added to the arguments too. > > Therefore, this patch changes qcom_ice_program_key() to take in all this > information as a struct blk_crypto_key directly. The calling code is > updated accordingly. This ends up being much simpler, and it makes the > key type be passed down automatically once wrapped key support is added. > > Based on a patch by Gaurav Kashyap that > replaced the byte array argument only. This patch makes the > blk_crypto_key replace other arguments like the algorithm ID too, > ensuring that there remains only one source of truth. > > Acked-by: Manivannan Sadhasivam > Tested-by: Bartosz Golaszewski # sm8650 > Signed-off-by: Eric Biggers > --- Acked-by: Konrad Dybcio Konrad