From: Bart Van Assche <bvanassche@acm.org>
To: Ming Lei <ming.lei@redhat.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Cc: Ewan Milne <emilne@redhat.com>
Subject: Re: [PATCH] scsi: core: move scsi_host_busy() out of host lock for waking up EH handler
Date: Tue, 23 Jan 2024 07:23:25 -0800 [thread overview]
Message-ID: <9ef3b977-747f-421f-9dee-2b8a5037424f@acm.org> (raw)
In-Reply-To: <20240112070000.4161982-1-ming.lei@redhat.com>
On 1/11/24 23:00, Ming Lei wrote:
> @@ -87,8 +87,10 @@ void scsi_schedule_eh(struct Scsi_Host *shost)
>
> if (scsi_host_set_state(shost, SHOST_RECOVERY) == 0 ||
> scsi_host_set_state(shost, SHOST_CANCEL_RECOVERY) == 0) {
> + unsigned int busy = scsi_host_busy(shost);
> +
> shost->host_eh_scheduled++;
> - scsi_eh_wakeup(shost);
> + scsi_eh_wakeup(shost, busy);
> }
No new variable is needed here. If this patch is reposted, please change
the above into the following:
+ scsi_eh_wakeup(shost, scsi_host_busy(shost));
With or without that additional change:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2024-01-23 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 7:00 [PATCH] scsi: core: move scsi_host_busy() out of host lock for waking up EH handler Ming Lei
2024-01-12 11:12 ` Hannes Reinecke
2024-01-12 12:42 ` Ming Lei
2024-01-12 19:34 ` Ewan Milne
2024-01-13 1:59 ` Ming Lei
2024-01-23 7:04 ` Sathya Prakash Veerichetty
2024-01-23 15:23 ` Bart Van Assche [this message]
2024-01-24 3:00 ` Martin K. Petersen
2024-02-03 2:31 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ef3b977-747f-421f-9dee-2b8a5037424f@acm.org \
--to=bvanassche@acm.org \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox