From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: cgel.zte@gmail.com
Cc: chi.minghao@zte.com.cn, jejb@linux.ibm.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, zealci@zte.com.cn
Subject: Re: [PATCH] drivers/scsi/csiostor: do not sleep with a spin lock held
Date: Wed, 19 Jan 2022 18:05:58 +0900 [thread overview]
Message-ID: <9f5428b2-4d36-29a1-ef1a-d544cec25bd7@opensource.wdc.com> (raw)
In-Reply-To: <20220119085754.932168-1-chi.minghao@zte.com.cn>
On 1/19/22 17:57, cgel.zte@gmail.com wrote:
>
> The might_sleep_if(gfp_mask & __GFP_DIRECT_RECLAIM) in the
> mempool_alloc function uses __GFP_DIRECT_RECLAIM.
But the call to mempool_alloc() specifies GFP_ATOMIC, which does not
have __GFP_DIRECT_RECLAIM, so "gfp_mask & __GFP_DIRECT_RECLAIM" should
be false, and the might_sleep_if() not triggering. How can you see the
might sleep warning ?
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-01-19 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 5:59 [PATCH] drivers/scsi/csiostor: do not sleep with a spin lock held cgel.zte
2022-01-19 8:45 ` Damien Le Moal
2022-01-19 8:57 ` cgel.zte
2022-01-19 9:05 ` Damien Le Moal [this message]
2022-01-19 9:22 ` cgel.zte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f5428b2-4d36-29a1-ef1a-d544cec25bd7@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox