From: Bart Van Assche <bvanassche@acm.org>
To: Jean Sacren <sakiwit@gmail.com>
Cc: Linux SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/1] scsi: Fix warning: zero-length gnu_printf format string
Date: Thu, 26 Aug 2010 08:00:07 +0200 [thread overview]
Message-ID: <AANLkTimQbCX9epuxSQ1NvTk5ejnWpA9jaENfwSAEC_wZ@mail.gmail.com> (raw)
In-Reply-To: <20100825235809.GA7160@mail.gmail.com>
On Thu, Aug 26, 2010 at 1:58 AM, Jean Sacren <sakiwit@gmail.com> wrote:
>
> warning: zero-length gnu_printf format string
>
> Fix the above warning by inserting a space into the literal string.
[ ... ]
> - scmd_printk(KERN_INFO, cmd, "");
> + scmd_printk(KERN_INFO, cmd, " ");
Hello Jean,
Have you considered to replace the empty string by "%s", "" or to
submit a patch that disables the compiler warning on empty format
strings ?
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-26 6:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 23:55 [PATCH 0/1] scsi: Fix warning: zero-length gnu_printf format string Jean Sacren
2010-08-25 23:58 ` [PATCH 1/1] " Jean Sacren
2010-08-26 6:00 ` Bart Van Assche [this message]
2010-08-26 14:28 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimQbCX9epuxSQ1NvTk5ejnWpA9jaENfwSAEC_wZ@mail.gmail.com \
--to=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sakiwit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).