From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: dave.jiang@intel.com, linux-scsi@vger.kernel.org,
jacek.danecki@intel.com, ed.ciechanowski@intel.com,
jeffrey.d.skirvin@intel.com, edmund.nadolski@intel.com
Subject: Re: [PATCH, RFC 0/2] scic: remove pointless stuctures
Date: Thu, 31 Mar 2011 15:24:25 -0700 [thread overview]
Message-ID: <AANLkTin-VOOBSwfoAFODWDMvjEjA0NV=x093qzyGAnpc@mail.gmail.com> (raw)
In-Reply-To: <20110328132046.GA497@infradead.org>
On Mon, Mar 28, 2011 at 6:20 AM, Christoph Hellwig <hch@infradead.org> wrote:
> Start killing off the pointless sci_base* structures which do nothing
> but causing a lot of unreadable code by converting forth and back
> between them and the real structures.
>
> I've done the sci_base_controller, and sci_base_request on a rainy
> sunday afternoon, but the port, phy and remote device also need the
> same treatment. And after that the sci_base_object crap needs to
> go in favour of just using container_of or properly typed pointers.
>
> But I'll rather leave that to you Intel guys, spending more time
> on this codebase won't be good for my mental health.
Understood, but it's not everyday you get to submit patches that
consistently have a 2x deletions/insertions ratio. In fact that has
been my rule of thumb for this driver for a while, any cleanup patch
that falls short of that ratio is probably too narrow of a cleanup.
--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-31 22:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 0:07 [PATCH] scic: remove mmio wrappers Christoph Hellwig
2011-03-28 13:20 ` [PATCH, RFC 0/2] scic: remove pointless stuctures Christoph Hellwig
2011-03-28 13:21 ` [PATCH 1/2] isci: remove base_controller abstraction Christoph Hellwig
2011-03-31 21:21 ` Dan Williams
2011-03-28 13:21 ` [PATCH 2/2] isci: remove base_request abstraction Christoph Hellwig
2011-03-31 22:14 ` Dan Williams
2011-04-01 13:11 ` Christoph Hellwig
2011-03-31 22:24 ` Dan Williams [this message]
2011-03-31 1:43 ` [PATCH] scic: remove mmio wrappers Dan Williams
2011-03-31 6:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTin-VOOBSwfoAFODWDMvjEjA0NV=x093qzyGAnpc@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=edmund.nadolski@intel.com \
--cc=hch@infradead.org \
--cc=jacek.danecki@intel.com \
--cc=jeffrey.d.skirvin@intel.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).