From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: James Bottomley <James.Bottomley@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] drivers: scsi: remove private hex_to_bin() implementation
Date: Wed, 22 Sep 2010 11:41:15 +0300 [thread overview]
Message-ID: <AANLkTin8C-3ktNzDc1dz0wTrq0915BibZRdNR7O4L9fw@mail.gmail.com> (raw)
In-Reply-To: <1284213395.2986.9.camel@mulgrave.site>
On Sat, Sep 11, 2010 at 4:56 PM, James Bottomley
<James.Bottomley@suse.de> wrote:
> the hex_to_bin() is really to prevent open coded mistakes. When the
> open coding pre-dates the hex_to_bin macro, I'm inclined to leave it
> alone unless it contains an actual bug.
It's also a matter of speed/size optimization. Nevertheless SCSI
subsystem already has such clean up.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2010-09-22 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-11 13:38 [PATCH] drivers: scsi: remove private hex_to_bin() implementation Andy Shevchenko
2010-09-11 13:56 ` James Bottomley
2010-09-22 8:41 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin8C-3ktNzDc1dz0wTrq0915BibZRdNR7O4L9fw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).