From: li jianyun <jianyunff@gmail.com>
To: Rolf Eike Beer <eike@sf-mail.de>
Cc: James.Bottomley@suse.de, Jianyun Li <jyli@marvell.com>,
"open list:SCSI SUBSYSTEM" <linux-scsi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v2] Add Marvell UMI driver
Date: Wed, 11 May 2011 21:17:25 +0800 [thread overview]
Message-ID: <BANLkTi=PyObf4pm7xF8jT7hcDgpJVrCdSg@mail.gmail.com> (raw)
In-Reply-To: <8883108.HpZuVnkiNA@donald.sf-tec.de>
2011/5/10 Rolf Eike Beer <eike@sf-mail.de>:
>
>
>> +static unsigned char tag_is_empty(struct tag_stack *st)
>> +{
>> + if (st->top == 0)
>> + return 1;
>> + else
>> + return 0;
>> +}
>
> The return value should be bool. But I don't think this function is worth it,
> I can only find one place where it is used at all.
>
it may be easy to understand. so I am not modify it.
next prev parent reply other threads:[~2011-05-11 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Message-Id>
2011-05-09 12:19 ` [PATCH v2] Add Marvell UMI driver Jianyun Li
2011-05-09 19:20 ` Jesse Barnes
2011-05-09 21:23 ` Rolf Eike Beer
2011-05-11 13:17 ` li jianyun [this message]
2011-05-11 15:22 ` [PATCH v3] " jianyunff
2011-06-14 2:33 ` li jianyun
2011-08-15 11:10 ` li jianyun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=PyObf4pm7xF8jT7hcDgpJVrCdSg@mail.gmail.com' \
--to=jianyunff@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=eike@sf-mail.de \
--cc=jyli@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).