From mboxrd@z Thu Jan 1 00:00:00 1970 From: li jianyun Subject: Re: [PATCH v2] Add Marvell UMI driver Date: Wed, 11 May 2011 21:17:25 +0800 Message-ID: References: <1304943577-2876-1-git-send-email-jianyunff@gmail.com> <8883108.HpZuVnkiNA@donald.sf-tec.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <8883108.HpZuVnkiNA@donald.sf-tec.de> Sender: linux-kernel-owner@vger.kernel.org To: Rolf Eike Beer Cc: James.Bottomley@suse.de, Jianyun Li , "open list:SCSI SUBSYSTEM" , open list , "open list:PCI SUBSYSTEM" List-Id: linux-scsi@vger.kernel.org 2011/5/10 Rolf Eike Beer : > > >> +static unsigned char tag_is_empty(struct tag_stack *st) >> +{ >> + =A0 =A0 if (st->top =3D=3D 0) >> + =A0 =A0 =A0 =A0 =A0 =A0 return 1; >> + =A0 =A0 else >> + =A0 =A0 =A0 =A0 =A0 =A0 return 0; >> +} > > The return value should be bool. But I don't think this function is w= orth it, > I can only find one place where it is used at all. > it may be easy to understand. so I am not modify it.