public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Salyzyn <Mark_Salyzyn@adaptec.com>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Linux SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] dpt_i2o: Add PROC_IA64 define
Date: Fri, 13 Jun 2008 10:40:35 -0400	[thread overview]
Message-ID: <C3C13D68-8451-429F-8EB6-7C2F770DFD72@adaptec.com> (raw)
In-Reply-To: <48528648.7070404@suse.com>

ACK!!!

Sincerely -- Mark Salyzyn

On Jun 13, 2008, at 10:38 AM, Jeff Mahoney wrote:

> Thanks for the feedback, Mark. Round two:
>
> This fixes the following compile failure:
> drivers/scsi/dpt_i2o.c:83: error: 'PROC_IA64' undeclared here (not  
> in a function)
>
> Mark Salyzyn <Mark_Salyzyn@adaptec.com> indicated that IA64 must  
> report
> itself as PROC_INTEL, so I've changed the comment for PROC_INTEL.
>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> ---
>
> drivers/scsi/dpt/dptsig.h |    3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- a/drivers/scsi/dpt/dptsig.h
> +++ b/drivers/scsi/dpt/dptsig.h
> @@ -85,7 +85,7 @@ typedef unsigned int sigINT;
> /*  
> ------------------------------------------------------------------ */
> /* What type of processor the file is meant to run on. */
> /* This will let us know whether to read sigWORDs as high/low or low/ 
> high. */
> -#define PROC_INTEL      0x00    /* Intel 80x86 */
> +#define PROC_INTEL      0x00    /* Intel 80x86/ia64 */
> #define PROC_MOTOROLA   0x01    /* Motorola 68K */
> #define PROC_MIPS4000   0x02    /* MIPS RISC 4000 */
> #define PROC_ALPHA      0x03    /* DEC Alpha */
> @@ -104,6 +104,7 @@ typedef unsigned int sigINT;
> #define PROC_486        0x08    /* Intel 80486 */
> #define PROC_PENTIUM    0x10    /* Intel 586 aka P5 aka Pentium */
> #define PROC_SEXIUM    0x20    /* Intel 686 aka P6 aka Pentium Pro  
> or MMX */
> +#define PROC_IA64      0x40    /* Intel IA64 processor */
>
> /* PROC_i960: */
> #define PROC_960RX      0x01    /* Intel 80960RC/RD */
>
> --
> Jeff Mahoney
> SUSE Labs


      reply	other threads:[~2008-06-13 14:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12  4:27 [PATCH] dpt_i2o: Add PROC_IA64 define Jeff Mahoney
2008-06-12 13:22 ` Mark Salyzyn
2008-06-13 14:38   ` Jeff Mahoney
2008-06-13 14:40     ` Mark Salyzyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C3C13D68-8451-429F-8EB6-7C2F770DFD72@adaptec.com \
    --to=mark_salyzyn@adaptec.com \
    --cc=jeffm@suse.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox