From: Linus Torvalds <torvalds@linux-foundation.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Jason Seba <jason.seba42@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Tomas Henzl <thenzl@redhat.com>,
Jack Wang <xjtuwjp@gmail.com>,
Suresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>,
Viswas G <Viswas.G@pmcs.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"JBottomley@parallels.com" <JBottomley@parallels.com>,
Vasanthalakshmi Tharmarajan
<Vasanthalakshmi.Tharmarajan@pmcs.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: spinlock_irqsave() && flags (Was: pm80xx: Spinlock fix)
Date: Mon, 23 Dec 2013 10:43:07 -0800 [thread overview]
Message-ID: <CA+55aFwPUVeZTn5-_RhvGTQA2v3TOPafGPH-JAEwdVA5qE4FSA@mail.gmail.com> (raw)
In-Reply-To: <20131223182455.GA5656@redhat.com>
On Mon, Dec 23, 2013 at 10:24 AM, Oleg Nesterov <oleg@redhat.com> wrote:
>
> However, the code above already has the users. Do you think it makes
> sense to add something like
No. I think it makes sense to put a big warning on any users you find,
and fart in the general direction of any developer who did that broken
pattern.
Because code like that is obviously crap.
Linus
next prev parent reply other threads:[~2013-12-23 18:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 11:28 [PATCH] pm80xx: Spinlock fix Viswas G
2013-12-23 13:07 ` Tomas Henzl
2013-12-23 13:32 ` Jack Wang
2013-12-23 13:45 ` Suresh Thiagarajan
2013-12-23 14:55 ` Jason Seba
2013-12-23 15:06 ` Jack Wang
2013-12-23 15:28 ` Tomas Henzl
2013-12-23 15:33 ` Jason Seba
2013-12-23 15:36 ` Tomas Henzl
2013-12-23 16:34 ` Oleg Nesterov
2013-12-23 17:27 ` spinlock_irqsave() && flags (Was: pm80xx: Spinlock fix) Oleg Nesterov
2013-12-23 18:12 ` Linus Torvalds
2013-12-23 18:24 ` Oleg Nesterov
2013-12-23 18:43 ` Linus Torvalds [this message]
2013-12-23 18:23 ` Ingo Molnar
2013-12-23 18:33 ` Oleg Nesterov
2013-12-24 8:29 ` Ingo Molnar
2013-12-24 9:13 ` Suresh Thiagarajan
2013-12-24 17:29 ` James Bottomley
2013-12-27 16:18 ` Oleg Nesterov
2014-01-02 10:31 ` Suresh Thiagarajan
2014-01-03 20:02 ` Dan Williams
2013-12-23 15:38 ` [PATCH] pm80xx: Spinlock fix Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFwPUVeZTn5-_RhvGTQA2v3TOPafGPH-JAEwdVA5qE4FSA@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=JBottomley@parallels.com \
--cc=Suresh.Thiagarajan@pmcs.com \
--cc=Vasanthalakshmi.Tharmarajan@pmcs.com \
--cc=Viswas.G@pmcs.com \
--cc=jason.seba42@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=thenzl@redhat.com \
--cc=xjtuwjp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).