From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [GIT PULL] SCSI fixes for 4.18-rc3 Date: Mon, 9 Jul 2018 17:41:34 -0700 Message-ID: References: <1530913134.3135.2.camel@HansenPartnership.com> <1530940958.3135.4.camel@HansenPartnership.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000000a608f05709a656b" Return-path: In-Reply-To: <1530940958.3135.4.camel@HansenPartnership.com> Sender: linux-kernel-owner@vger.kernel.org To: James Bottomley Cc: Jann Horn , Andrew Morton , Linux SCSI List , Linux Kernel Mailing List List-Id: linux-scsi@vger.kernel.org --0000000000000a608f05709a656b Content-Type: text/plain; charset="UTF-8" On Fri, Jul 6, 2018 at 10:22 PM James Bottomley wrote: > > We did discuss removing the r/w interface, but, as you say, it's been > around for ages so it's not clear what regressions would surface if we > did. So since nobody else followed up on this, the attached patch is what I was thinking of just committing. It removes the warnings from the access check, and just puts them (unconditionally) at the top of the read/write function instead. Hmm? Linus --0000000000000a608f05709a656b Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jjeyztoj0 IGRyaXZlcnMvc2NzaS9zZy5jIHwgMjIgKysrKysrKysrKystLS0tLS0tLS0tLQogMSBmaWxlIGNo YW5nZWQsIDExIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2Ry aXZlcnMvc2NzaS9zZy5jIGIvZHJpdmVycy9zY3NpL3NnLmMKaW5kZXggY2QyZmRhYzAwMGM5Li4w OTMyNWI4ZmJjOWYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvc2NzaS9zZy5jCisrKyBiL2RyaXZlcnMv c2NzaS9zZy5jCkBAIC0yMjIsMTggKzIyMiwxMiBAQCBzdGF0aWMgdm9pZCBzZ19kZXZpY2VfZGVz dHJveShzdHJ1Y3Qga3JlZiAqa3JlZik7CiAgKiBUaGlzIGZ1bmN0aW9uIHByb3ZpZGVzIHByb3Rl Y3Rpb24gZm9yIHRoZSBsZWdhY3kgQVBJIGJ5IHJlc3RyaWN0aW5nIHRoZQogICogY2FsbGluZyBj b250ZXh0LgogICovCi1zdGF0aWMgaW50IHNnX2NoZWNrX2ZpbGVfYWNjZXNzKHN0cnVjdCBmaWxl ICpmaWxwLCBjb25zdCBjaGFyICpjYWxsZXIpCitzdGF0aWMgaW50IHNnX2NoZWNrX2ZpbGVfYWNj ZXNzKHN0cnVjdCBmaWxlICpmaWxwKQogewotCWlmIChmaWxwLT5mX2NyZWQgIT0gY3VycmVudF9y ZWFsX2NyZWQoKSkgewotCQlwcl9lcnJfb25jZSgiJXM6IHByb2Nlc3MgJWQgKCVzKSBjaGFuZ2Vk IHNlY3VyaXR5IGNvbnRleHRzIGFmdGVyIG9wZW5pbmcgZmlsZSBkZXNjcmlwdG9yLCB0aGlzIGlz IG5vdCBhbGxvd2VkLlxuIiwKLQkJCWNhbGxlciwgdGFza190Z2lkX3ZucihjdXJyZW50KSwgY3Vy cmVudC0+Y29tbSk7CisJaWYgKGZpbHAtPmZfY3JlZCAhPSBjdXJyZW50X3JlYWxfY3JlZCgpKQog CQlyZXR1cm4gLUVQRVJNOwotCX0KLQlpZiAodWFjY2Vzc19rZXJuZWwoKSkgewotCQlwcl9lcnJf b25jZSgiJXM6IHByb2Nlc3MgJWQgKCVzKSBjYWxsZWQgZnJvbSBrZXJuZWwgY29udGV4dCwgdGhp cyBpcyBub3QgYWxsb3dlZC5cbiIsCi0JCQljYWxsZXIsIHRhc2tfdGdpZF92bnIoY3VycmVudCks IGN1cnJlbnQtPmNvbW0pOworCWlmICh1YWNjZXNzX2tlcm5lbCgpKQogCQlyZXR1cm4gLUVBQ0NF UzsKLQl9CiAJcmV0dXJuIDA7CiB9CiAKQEAgLTQyMSwxMSArNDE1LDE0IEBAIHNnX3JlYWQoc3Ry dWN0IGZpbGUgKmZpbHAsIGNoYXIgX191c2VyICpidWYsIHNpemVfdCBjb3VudCwgbG9mZl90ICog cHBvcykKIAlzdHJ1Y3Qgc2dfaGVhZGVyICpvbGRfaGRyID0gTlVMTDsKIAlpbnQgcmV0dmFsID0g MDsKIAorCXByX2Vycl9vbmNlKCJwcm9jZXNzICVkICglcykgZG9lcyBkaXJlY3QgcmVhZCBvbiAv ZGV2L3NnIiwKKwkJdGFza190Z2lkX3ZucihjdXJyZW50KSwgY3VycmVudC0+Y29tbSk7CisKIAkv KgogCSAqIFRoaXMgY291bGQgY2F1c2UgYSByZXNwb25zZSB0byBiZSBzdHJhbmRlZC4gQ2xvc2Ug dGhlIGFzc29jaWF0ZWQKIAkgKiBmaWxlIGRlc2NyaXB0b3IgdG8gZnJlZSB1cCBhbnkgcmVzb3Vy Y2VzIGJlaW5nIGhlbGQuCiAJICovCi0JcmV0dmFsID0gc2dfY2hlY2tfZmlsZV9hY2Nlc3MoZmls cCwgX19mdW5jX18pOworCXJldHZhbCA9IHNnX2NoZWNrX2ZpbGVfYWNjZXNzKGZpbHApOwogCWlm IChyZXR2YWwpCiAJCXJldHVybiByZXR2YWw7CiAKQEAgLTYxOCw3ICs2MTUsMTAgQEAgc2dfd3Jp dGUoc3RydWN0IGZpbGUgKmZpbHAsIGNvbnN0IGNoYXIgX191c2VyICpidWYsIHNpemVfdCBjb3Vu dCwgbG9mZl90ICogcHBvcykKIAl1bnNpZ25lZCBjaGFyIGNtbmRbU0dfTUFYX0NEQl9TSVpFXTsK IAlpbnQgcmV0dmFsOwogCi0JcmV0dmFsID0gc2dfY2hlY2tfZmlsZV9hY2Nlc3MoZmlscCwgX19m dW5jX18pOworCXByX2Vycl9vbmNlKCJwcm9jZXNzICVkICglcykgZG9lcyBkaXJlY3Qgd3JpdGUg b24gL2Rldi9zZyIsCisJCXRhc2tfdGdpZF92bnIoY3VycmVudCksIGN1cnJlbnQtPmNvbW0pOwor CisJcmV0dmFsID0gc2dfY2hlY2tfZmlsZV9hY2Nlc3MoZmlscCk7CiAJaWYgKHJldHZhbCkKIAkJ cmV0dXJuIHJldHZhbDsKIAo= --0000000000000a608f05709a656b--