From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jann Horn <jannh@google.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux SCSI List <linux-scsi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] SCSI fixes for 4.18-rc3
Date: Tue, 10 Jul 2018 10:49:42 -0700 [thread overview]
Message-ID: <CA+55aFx9iTm2rZqL1jo_mhAp7EQ8tHhU6MFCSG7XdqAxY_vUGw@mail.gmail.com> (raw)
In-Reply-To: <CAG48ez0Ccpp3yv+FVX9Sp3WHqPh6US=quDjELmv5RYVgqfBtVg@mail.gmail.com>
On Tue, Jul 10, 2018 at 10:36 AM Jann Horn <jannh@google.com> wrote:
>
> AFAICS it does mean that if two processes use /dev/sg* - the first one
> in a way that passes sg_check_file_access(), the second one in a way
> that gets blocked for whatever reason -, the pr_err_once() will fire
> for the process that's working and not fire for the one that got
> blocked. But if nobody should be using that interface anyway, I guess
> that's not a practical concern.
Right. I don't expect it to trigger at all, and the "working" program
should be fixed too, because I want for us to be able to just remove
that idiotic direct access thing.
> Also, the device is called /dev/sg%d with %d being sdp->index.
I guess I could make it at least say that, although it's not like "one
of them would be ok, but /dev/sd3 is right out".
Linus
next prev parent reply other threads:[~2018-07-10 17:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 21:38 [GIT PULL] SCSI fixes for 4.18-rc3 James Bottomley
2018-07-07 2:31 ` Linus Torvalds
2018-07-07 2:39 ` Linus Torvalds
2018-07-07 2:48 ` Linus Torvalds
2018-07-07 5:22 ` James Bottomley
2018-07-10 0:41 ` Linus Torvalds
2018-07-10 17:36 ` Jann Horn
2018-07-10 17:49 ` Linus Torvalds [this message]
2018-07-10 18:04 ` Linus Torvalds
2018-07-10 21:53 ` Tony Battersby
2018-07-10 22:24 ` Linus Torvalds
2018-07-11 0:40 ` Linus Torvalds
2018-07-11 6:45 ` Christoph Hellwig
2018-07-11 13:56 ` Tony Battersby
2018-07-16 16:20 ` Jann Horn
2018-07-07 3:08 ` Jann Horn
2018-07-07 3:25 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFx9iTm2rZqL1jo_mhAp7EQ8tHhU6MFCSG7XdqAxY_vUGw@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).