From: Jack Wang <jack.wang.usish@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Wang Jinpu <xjtuwjp@gmail.com>,
stable@vger.kernel.org, Jinpu Wang <jinpu.wang@profitbricks.com>
Subject: Re: [stable-4.14 00/23] block/scsi multiqueue performance enhancement and
Date: Mon, 23 Jul 2018 17:37:40 +0200 [thread overview]
Message-ID: <CA+res+RSPJ326FWvH5e6ROx1rdHMBTses8vgEBJ72sOMrHjiOA@mail.gmail.com> (raw)
In-Reply-To: <0c2c50c4-3a17-c0cd-6ece-4f2ca6e30dde@kernel.dk>
Jens Axboe <axboe@kernel.dk> 于2018年7月23日周一 下午5:31写道:
>
> On 7/23/18 9:28 AM, Jack Wang wrote:
> > Jens Axboe <axboe@kernel.dk> 于2018年7月23日周一 下午5:05写道:
> >>
> >> On 7/23/18 9:00 AM, Jack Wang wrote:
> >>> Hi Greg,
> >>>
> >>> Thanks for quick reply. Please see reply inline.
> >>>
> >>>
> >>>
> >>> Greg KH <gregkh@linuxfoundation.org> 于2018年7月23日周一 下午3:34写道:
> >>>>
> >>>> On Mon, Jul 23, 2018 at 03:24:22PM +0200, Jack Wang wrote:
> >>>>> Hi Greg,
> >>>>>
> >>>>> Please consider this patchset, which include block/scsi multiqueue performance
> >>>>> enhancement and bugfix.
> >>>>
> >>>> What exactly is the performance enhancement? How can you measure it?
> >>>> How did you measure it?
> >>> I'm testing on SRP/IBNBD using fio, I've seen +10% with mix IO load,
> >>> and 50% improvement on small IO (bs=512.) with the patchset.
> >>
> >> Big nak on backporting this huge series, it's a lot of core changes.
> >> It's way beyond the scope of a stable fix backport.
> >>
> >> --
> >> Jens Axboe
> >>
> > OK, could you shed light on how could we fix the queue stall problem on 4.14?
> > My colleague Roman reported to upstream:
> > https://lkml.org/lkml/2017/10/18/263
> >
> > It's still there on latest 4.14.
>
> The proposed patch is a helluva lot simpler than doing a 23 patch selective
> backport.
>
> --
> Jens Axboe
>
Do you think it make sense to port Roman's patch to upstream 4.14?
So others would also be benifitial?
On the other side, stable tree only takes patches accepted into Linus tree.
Thanks,
Jack
prev parent reply other threads:[~2018-07-23 15:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1532352285-13589-1-git-send-email-jinpuwang@gmail.com>
[not found] ` <20180723133356.GA1333@kroah.com>
2018-07-23 15:00 ` [stable-4.14 00/23] block/scsi multiqueue performance enhancement and Jack Wang
2018-07-23 15:05 ` Jens Axboe
2018-07-23 15:28 ` Jack Wang
2018-07-23 15:31 ` Jens Axboe
2018-07-23 15:37 ` Jack Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+res+RSPJ326FWvH5e6ROx1rdHMBTses8vgEBJ72sOMrHjiOA@mail.gmail.com \
--to=jack.wang.usish@gmail.com \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=jinpu.wang@profitbricks.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=xjtuwjp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).