Re: [PATCH 1/4] scsi_debug: fix endianness bug in sdebug_build_parts()

[Akinobu Mita <akinobu.mita@gmail.com>]

2013/7/26 Martin Peschke <mpeschke@linux.vnet.ibm.com>:
> On Mon, 2013-07-15 at 20:52 +0900, Akinobu Mita wrote:
>> With module parameter num_parts > 0, partition table is built on the
>> ramdisk storage when loading the driver.  Unfortunately, there is an
>> endianness bug in sdebug_build_parts().  So the partition table is not
>> correctly initialized on big-endian systems.
>>
>> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
>> Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
>> Cc: Douglas Gilbert <dgilbert@interlog.com>
>> Cc: linux-scsi@vger.kernel.org
>> ---
>>  drivers/scsi/scsi_debug.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
>> index cb4fefa..2f39b13 100644
>> --- a/drivers/scsi/scsi_debug.c
>> +++ b/drivers/scsi/scsi_debug.c
>> @@ -2659,8 +2659,8 @@ static void __init sdebug_build_parts(unsigned char *ramp,
>>                              / sdebug_sectors_per;
>>               pp->end_sector = (end_sec % sdebug_sectors_per) + 1;
>>
>> -             pp->start_sect = start_sec;
>> -             pp->nr_sects = end_sec - start_sec + 1;
>> +             pp->start_sect = cpu_to_le32(start_sec);
>> +             pp->nr_sects = cpu_to_le32(end_sec - start_sec + 1);
>>               pp->sys_ind = 0x83;     /* plain Linux partition */
>>       }
>>  }
>
>
> I have posted the same fix several times, e.g.
> http://marc.info/?l=linux-scsi&m=137051617907423&w=2
> Good luck!
>
> Acked-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>

Thanks.  I found this problem from sparse warning noticed by 0-DAY kernel
build testing.