From: Roland Dreier <roland@kernel.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
Chad Dupuis <chad.dupuis@qlogic.com>,
Arun Easi <arun.easi@qlogic.com>
Subject: Re: [PATCH] qla2xxx: Fix endianness of task management response code
Date: Fri, 21 Sep 2012 01:09:10 -0700 [thread overview]
Message-ID: <CAG4TOxOehsQz++nWWOGw12Zyp2AsWbrQy9D4faLxuay=2jXDZA@mail.gmail.com> (raw)
In-Reply-To: <1348214576.2468.1.camel@dabdike.int.hansenpartnership.com>
On Fri, Sep 21, 2012 at 1:02 AM, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
> The data in status1 appears to get used a word at a time ... what about
> the other three bytes you don't set; are they guaranteed to be zero? (in
> which case this works, it just looks wrong from the way the thing is
> used in the rest of the code).
Yes, the structure comes from
ctio = (struct ctio7_to_24xx *)qla2x00_alloc_iocbs(ha, NULL);
a few lines earlier, and that does:
/* Prep packet */
memset(pkt, 0, REQUEST_ENTRY_SIZE);
before
return pkt;
prev parent reply other threads:[~2012-09-21 8:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 22:10 [PATCH] qla2xxx: Fix endianness of task management response code Roland Dreier
2012-09-18 22:24 ` Nicholas A. Bellinger
2012-09-19 7:04 ` Saurav Kashyap
2012-09-19 5:43 ` Saurav Kashyap
2012-09-22 23:52 ` Nicholas A. Bellinger
2012-09-19 7:59 ` James Bottomley
2012-09-19 14:09 ` Roland Dreier
2012-09-21 8:02 ` James Bottomley
2012-09-21 8:09 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG4TOxOehsQz++nWWOGw12Zyp2AsWbrQy9D4faLxuay=2jXDZA@mail.gmail.com' \
--to=roland@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arun.easi@qlogic.com \
--cc=chad.dupuis@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).