From: adam radford <aradford@gmail.com>
To: linux-scsi <linux-scsi@vger.kernel.org>,
kashyap.desai@avagotech.com, sumit.saxena@avagotech.com,
uday.lingala@avagotech.com
Subject: [PATCH 1/4] megaraid_sas: Fix reset_mutex leak
Date: Thu, 19 Jun 2014 17:31:30 -0700 [thread overview]
Message-ID: <CAHtARFHPrfWho2k5xu8dbXiKtFC4RQsp=MrpgNbhaii33aDGSg@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
James/linux-scsi,
The following patch for megaraid_sas fixes a reset_mutex leak in
megasas_reset_fusion().
Signed-off-by: Adam Radford <aradford@gmail.com>
diff -Naur scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas_fusion.c
scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas_fusion.c
--- scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas_fusion.c
2014-06-19 15:03:05.000000000 -0700
+++ scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas_fusion.c
2014-06-19 15:24:19.982075881 -0700
@@ -2355,6 +2355,7 @@
printk(KERN_WARNING "megaraid_sas: Hardware critical error, "
"returning FAILED for scsi%d.\n",
instance->host->host_no);
+ mutex_unlock(&instance->reset_mutex);
return FAILED;
}
[-- Attachment #2: megaraid_sas.patch1 --]
[-- Type: application/octet-stream, Size: 565 bytes --]
diff -Naur scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas_fusion.c scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas_fusion.c
--- scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas_fusion.c 2014-06-19 15:03:05.000000000 -0700
+++ scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas_fusion.c 2014-06-19 15:24:19.982075881 -0700
@@ -2355,6 +2355,7 @@
printk(KERN_WARNING "megaraid_sas: Hardware critical error, "
"returning FAILED for scsi%d.\n",
instance->host->host_no);
+ mutex_unlock(&instance->reset_mutex);
return FAILED;
}
next reply other threads:[~2014-06-20 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 0:31 adam radford [this message]
2014-06-26 1:51 ` [PATCH 1/4] megaraid_sas: Fix reset_mutex leak Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2014-07-01 0:19 [PATCH 0/4] megaraid_sas: Update for scsi for-next Adam Radford
2014-07-01 0:19 ` [PATCH 1/4] megaraid_sas: Fix reset_mutex leak Adam Radford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHtARFHPrfWho2k5xu8dbXiKtFC4RQsp=MrpgNbhaii33aDGSg@mail.gmail.com' \
--to=aradford@gmail.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sumit.saxena@avagotech.com \
--cc=uday.lingala@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).