* [PATCH 1/4] megaraid_sas: Fix reset_mutex leak
@ 2014-06-20 0:31 adam radford
2014-06-26 1:51 ` Martin K. Petersen
0 siblings, 1 reply; 3+ messages in thread
From: adam radford @ 2014-06-20 0:31 UTC (permalink / raw)
To: linux-scsi, kashyap.desai, sumit.saxena, uday.lingala
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
James/linux-scsi,
The following patch for megaraid_sas fixes a reset_mutex leak in
megasas_reset_fusion().
Signed-off-by: Adam Radford <aradford@gmail.com>
diff -Naur scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas_fusion.c
scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas_fusion.c
--- scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas_fusion.c
2014-06-19 15:03:05.000000000 -0700
+++ scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas_fusion.c
2014-06-19 15:24:19.982075881 -0700
@@ -2355,6 +2355,7 @@
printk(KERN_WARNING "megaraid_sas: Hardware critical error, "
"returning FAILED for scsi%d.\n",
instance->host->host_no);
+ mutex_unlock(&instance->reset_mutex);
return FAILED;
}
[-- Attachment #2: megaraid_sas.patch1 --]
[-- Type: application/octet-stream, Size: 565 bytes --]
diff -Naur scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas_fusion.c scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas_fusion.c
--- scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas_fusion.c 2014-06-19 15:03:05.000000000 -0700
+++ scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas_fusion.c 2014-06-19 15:24:19.982075881 -0700
@@ -2355,6 +2355,7 @@
printk(KERN_WARNING "megaraid_sas: Hardware critical error, "
"returning FAILED for scsi%d.\n",
instance->host->host_no);
+ mutex_unlock(&instance->reset_mutex);
return FAILED;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/4] megaraid_sas: Fix reset_mutex leak
2014-06-20 0:31 [PATCH 1/4] megaraid_sas: Fix reset_mutex leak adam radford
@ 2014-06-26 1:51 ` Martin K. Petersen
0 siblings, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2014-06-26 1:51 UTC (permalink / raw)
To: adam radford; +Cc: linux-scsi, kashyap.desai, sumit.saxena, uday.lingala
>>>>> "adam" == adam radford <aradford@gmail.com> writes:
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/4] megaraid_sas: Fix reset_mutex leak
2014-07-01 0:19 [PATCH 0/4] megaraid_sas: Update for scsi for-next Adam Radford
@ 2014-07-01 0:19 ` Adam Radford
0 siblings, 0 replies; 3+ messages in thread
From: Adam Radford @ 2014-07-01 0:19 UTC (permalink / raw)
To: linux-scsi, kashyap.desai, sumit.saxena, uday.lingala; +Cc: Adam Radford
James/linux-scsi,
The following patch for megaraid_sas fixes a reset_mutex leak in megasas_reset_fusion().
Signed-off-by: Adam Radford <aradford@gmail.com>
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 2260041..0858851 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -2355,6 +2355,7 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int iotimeout)
printk(KERN_WARNING "megaraid_sas: Hardware critical error, "
"returning FAILED for scsi%d.\n",
instance->host->host_no);
+ mutex_unlock(&instance->reset_mutex);
return FAILED;
}
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-01 0:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-20 0:31 [PATCH 1/4] megaraid_sas: Fix reset_mutex leak adam radford
2014-06-26 1:51 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2014-07-01 0:19 [PATCH 0/4] megaraid_sas: Update for scsi for-next Adam Radford
2014-07-01 0:19 ` [PATCH 1/4] megaraid_sas: Fix reset_mutex leak Adam Radford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).