[PATCH 1/4] megaraid_sas: Fix reset_mutex leak

[PATCH 1/4] megaraid_sas: Fix reset_mutex leak

[adam radford]

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

James/linux-scsi,

The following patch for megaraid_sas fixes a reset_mutex leak in
megasas_reset_fusion().

Signed-off-by: Adam Radford <aradford@gmail.com>

diff -Naur scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas_fusion.c
scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas_fusion.c
--- scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas_fusion.c
2014-06-19 15:03:05.000000000 -0700
+++ scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas_fusion.c
2014-06-19 15:24:19.982075881 -0700
@@ -2355,6 +2355,7 @@
  printk(KERN_WARNING "megaraid_sas: Hardware critical error, "
        "returning FAILED for scsi%d.\n",
  instance->host->host_no);
+ mutex_unlock(&instance->reset_mutex);
  return FAILED;
  }

[-- Attachment #2: megaraid_sas.patch1 --]
[-- Type: application/octet-stream, Size: 565 bytes --]

diff -Naur scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas_fusion.c scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas_fusion.c
--- scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas_fusion.c	2014-06-19 15:03:05.000000000 -0700
+++ scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas_fusion.c	2014-06-19 15:24:19.982075881 -0700
@@ -2355,6 +2355,7 @@
 		printk(KERN_WARNING "megaraid_sas: Hardware critical error, "
 		       "returning FAILED for scsi%d.\n",
 			instance->host->host_no);
+		mutex_unlock(&instance->reset_mutex);
 		return FAILED;
 	}
 

Re: [PATCH 1/4] megaraid_sas: Fix reset_mutex leak

[Martin K. Petersen]

>>>>> "adam" == adam radford <aradford@gmail.com> writes:

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering

[PATCH 0/4] megaraid_sas: Update for scsi for-next

[Adam Radford]

(Re-sending with git-send-email on advice of Martin Petersen @ Oracle)

James/linux-scsi,

The following patch series for megaraid_sas brings the driver up to
v06.803.02.00-rc1.

1. Fix reset_mutex leak in megasas_reset_fusion().
2. Remove unused variables in megasas_instance.
3. Fix LD/VF affiliation parsing.
4. Version and Changelog update.

Adam Radford (4):
  megaraid_sas: Fix reset_mutex leak
  megaraid_sas: Removed unused variables in megasas_instance
  megaraid_sas: Fix LD/VF affiliation parsing
  megaraid_sas: Version and Changelog update

 Documentation/scsi/ChangeLog.megaraid_sas   | 13 +++++
 drivers/scsi/megaraid/megaraid_sas.h        |  9 ++-
 drivers/scsi/megaraid/megaraid_sas_base.c   | 90 ++++++++++++++++++++---------
 drivers/scsi/megaraid/megaraid_sas_fusion.c |  1 +
 4 files changed, 82 insertions(+), 31 deletions(-)

-- 
1.7.11.7

[PATCH 1/4] megaraid_sas: Fix reset_mutex leak

[Adam Radford]

James/linux-scsi,

The following patch for megaraid_sas fixes a reset_mutex leak in megasas_reset_fusion().

Signed-off-by: Adam Radford <aradford@gmail.com>
---
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 2260041..0858851 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -2355,6 +2355,7 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int iotimeout)
 		printk(KERN_WARNING "megaraid_sas: Hardware critical error, "
 		       "returning FAILED for scsi%d.\n",
 			instance->host->host_no);
+		mutex_unlock(&instance->reset_mutex);
 		return FAILED;
 	}
 
-- 
1.7.11.7