From: Or Gerlitz <gerlitz.or@gmail.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: target-devel@vger.kernel.org,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
kxie@chelsio.com, indranil@chelsio.com,
Steve Wise <swise@opengridcomputing.com>,
Varun Prakash <varun@chelsio.com>
Subject: Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko
Date: Wed, 18 May 2016 14:45:42 +0300 [thread overview]
Message-ID: <CAJ3xEMgtsPiatZ-Cy2ENsGVyKVDQSSHi4jr0Ushg21JiuqdLcw@mail.gmail.com> (raw)
In-Reply-To: <CAJ3xEMiyQaWwsgVd_J9eVXqPwPk6=VYN_iMoEJQGz=1wHFrHqQ@mail.gmail.com>
On Sat, Apr 30, 2016 at 6:54 PM, Or Gerlitz <gerlitz.or@gmail.com> wrote:
> On Tue, Apr 19, 2016 at 9:30 PM, Varun Prakash <varun@chelsio.com> wrote:
>> cxgbit.h - This file contains data structure
>> definitions for cxgbit.ko.
>>
>> cxgbit_lro.h - This file contains data structure
>> definitions for LRO support.
>>
>> cxgbit_main.c - This file contains code for
>> registering with iscsi target transport and
>> cxgb4 driver.
>>
>> cxgbit_cm.c - This file contains code for
>> connection management.
>>
>> cxgbit_target.c - This file contains code
>> for processing iSCSI PDU.
>>
>> cxgbit_ddp.c - This file contains code for
>> Direct Data Placement.
>
> Wait,
>
> You are adding many K's LOCs to handle things like CM (connection
> management), DDP and LRO. But your upstream solution must be using CM
> and DDP (and LRO as well) for the HW offloaded initiator side as well,
> not to mention the iWARP side of things.
>
> There must be some way to refactor things instead of repeating the
> same bits over and over, thoughts?
Nic,
The author haven't responded... where that this stands from your point of view?
Or.
>> drivers/target/iscsi/Kconfig | 2 +
>> drivers/target/iscsi/Makefile | 1 +
>> drivers/target/iscsi/cxgbit/Kconfig | 7 +
>> drivers/target/iscsi/cxgbit/Makefile | 6 +
>> drivers/target/iscsi/cxgbit/cxgbit.h | 353 +++++
>> drivers/target/iscsi/cxgbit/cxgbit_cm.c | 2086 +++++++++++++++++++++++++++
>> drivers/target/iscsi/cxgbit/cxgbit_ddp.c | 325 +++++
>> drivers/target/iscsi/cxgbit/cxgbit_lro.h | 72 +
>> drivers/target/iscsi/cxgbit/cxgbit_main.c | 701 +++++++++
>> drivers/target/iscsi/cxgbit/cxgbit_target.c | 1561 ++++++++++++++++++++
>> 10 files changed, 5114 insertions(+)
next prev parent reply other threads:[~2016-05-18 11:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 18:30 [PATCH v3 00/13] Chelsio iSCSI target offload driver Varun Prakash
2016-04-19 18:30 ` [PATCH v3 01/13] iscsi-target: add int (*iscsit_xmit_pdu)() Varun Prakash
2016-04-19 18:30 ` [PATCH v3 02/13] iscsi-target: add void (*iscsit_release_cmd)() Varun Prakash
2016-04-19 18:30 ` [PATCH v3 03/13] iscsi-target: add void (*iscsit_get_rx_pdu)() Varun Prakash
2016-08-09 3:19 ` Andy Grover
2016-08-13 16:56 ` Varun Prakash
2016-04-19 18:30 ` [PATCH v3 04/13] iscsi-target: split iscsi_target_rx_thread() Varun Prakash
2016-04-19 18:30 ` [PATCH v3 05/13] iscsi-target: add int (*iscsit_validate_params)() Varun Prakash
2016-04-19 18:30 ` [PATCH v3 06/13] iscsi-target: add void (*iscsit_get_r2t_ttt)() Varun Prakash
2016-04-19 18:30 ` [PATCH v3 07/13] iscsi-target: move iscsit_thread_check_cpumask() Varun Prakash
2016-04-19 18:30 ` [PATCH v3 08/13] iscsi-target: use conn_transport->transport_type in text rsp Varun Prakash
2016-04-19 18:30 ` [PATCH v3 09/13] iscsi-target: add new offload transport type Varun Prakash
2016-04-19 18:30 ` [PATCH v3 10/13] iscsi-target: clear tx_thread_active Varun Prakash
2016-04-19 18:30 ` [PATCH v3 11/13] iscsi-target: call complete on conn_logout_comp Varun Prakash
2016-04-19 18:30 ` [PATCH v3 12/13] iscsi-target: export symbols Varun Prakash
2016-04-19 18:30 ` [PATCH v3 13/13] cxgbit: add files for cxgbit.ko Varun Prakash
2016-04-30 15:54 ` Or Gerlitz
2016-05-18 11:45 ` Or Gerlitz [this message]
2016-05-24 6:40 ` Nicholas A. Bellinger
2016-05-25 15:04 ` Or Gerlitz
2016-05-25 17:40 ` Steve Wise
2016-05-25 20:41 ` Or Gerlitz
2016-05-26 4:55 ` Nicholas A. Bellinger
2016-05-26 18:58 ` Varun Prakash
2016-07-05 21:24 ` Or Gerlitz
2016-07-06 17:17 ` Varun Prakash
2016-07-07 7:54 ` Or Gerlitz
2016-07-08 18:03 ` Varun Prakash
2016-07-08 18:36 ` Steve Wise
2016-07-12 7:53 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3xEMgtsPiatZ-Cy2ENsGVyKVDQSSHi4jr0Ushg21JiuqdLcw@mail.gmail.com \
--to=gerlitz.or@gmail.com \
--cc=indranil@chelsio.com \
--cc=kxie@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=swise@opengridcomputing.com \
--cc=target-devel@vger.kernel.org \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).